Bug 213527 - Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled
Summary: Make HTTP/3 experimental feature work on iOS and only create storage director...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-23 12:49 PDT by Alex Christensen
Modified: 2020-06-23 23:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2020-06-23 12:53 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (7.35 KB, patch)
2020-06-23 13:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.55 KB, patch)
2020-06-23 15:50 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.81 KB, patch)
2020-06-23 16:06 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-06-23 12:49:57 PDT 
Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled
Comment 1 Alex Christensen 2020-06-23 12:53:33 PDT 
Created attachment 402583 [details]
Patch
Comment 2 Sam Weinig 2020-06-23 13:25:28 PDT 
Comment on attachment 402583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402583&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:212
> +#if PLATFORM(MAC)
> +    NSString *format = @"Experimental%@";
> +#else
> +    NSString *format = @"WebKitExperimental%@";
> +#endif

Is this correct for Catalyst?
Comment 3 Alex Christensen 2020-06-23 13:32:03 PDT 
I don't know but it doesn't matter in this case.  This is so users can use Safari's experimental features menu to turn on HTTP/3, and Safari is not a Catalyst app.
Comment 4 Guoye Zhang 2020-06-23 13:38:45 PDT 
WebKit currently has this:
> configuration._allowsHTTP3 = parameters.http3Enabled;

It’d be better if this is done instead:
> if (parameters.http3Enabled) {
>     configuration._allowsHTTP3 = YES;
> }

Which won't override system level "enable HTTP/3 by default"
Comment 5 Alex Christensen 2020-06-23 13:52:00 PDT 
Created attachment 402586 [details]
Patch
Comment 6 Geoffrey Garen 2020-06-23 14:13:49 PDT 
Seems like a great thing to add a regression test for.
Comment 7 Alex Christensen 2020-06-23 15:50:37 PDT 
Created attachment 402600 [details]
Patch
Comment 8 Alex Christensen 2020-06-23 16:06:41 PDT 
Created attachment 402602 [details]
Patch
Comment 9 Geoffrey Garen 2020-06-23 19:15:07 PDT 
Comment on attachment 402602 [details]
Patch

r=me
Comment 10 EWS 2020-06-23 23:04:30 PDT 
Committed r263441: <https://trac.webkit.org/changeset/263441>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402602 [details].
Comment 11 Radar WebKit Bug Importer 2020-06-23 23:05:18 PDT 
<rdar://problem/64685323>