Bug 213527 – Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled

[Alex Christensen]

Created attachment 402583 [details]
Patch

[Sam Weinig]

Comment on attachment 402583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402583&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:212
> +#if PLATFORM(MAC)
> +    NSString *format = @"Experimental%@";
> +#else
> +    NSString *format = @"WebKitExperimental%@";
> +#endif

Is this correct for Catalyst?

[Alex Christensen]

I don't know but it doesn't matter in this case.  This is so users can use Safari's experimental features menu to turn on HTTP/3, and Safari is not a Catalyst app.

[Guoye Zhang]

WebKit currently has this:
> configuration._allowsHTTP3 = parameters.http3Enabled;

It’d be better if this is done instead:
> if (parameters.http3Enabled) {
>     configuration._allowsHTTP3 = YES;
> }

Which won't override system level "enable HTTP/3 by default"

[Alex Christensen]

Created attachment 402586 [details]
Patch

[Geoffrey Garen]

Seems like a great thing to add a regression test for.

[Alex Christensen]

Created attachment 402600 [details]
Patch

[Alex Christensen]

Created attachment 402602 [details]
Patch

[Geoffrey Garen]

Comment on attachment 402602 [details]
Patch

r=me

[EWS]

Committed r263441: <https://trac.webkit.org/changeset/263441>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402602 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64685323>