Bug 213525 - [JSC] Clobberize misses `write(Heap)` report in some nodes
Summary: [JSC] Clobberize misses `write(Heap)` report in some nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 213551
Blocks:
  Show dependency tree / graph
 
Reported: 2020-06-23 11:44 PDT by Yusuke Suzuki
Modified: 2020-06-24 03:41 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2020-06-23 11:46 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Patch for landing (3.94 KB, patch)
2020-06-23 11:57 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (3.93 KB, patch)
2020-06-23 11:59 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-06-23 11:44:46 PDT 
[JSC] Clobberize misses `write(World)` report in some nodes
Comment 1 Yusuke Suzuki 2020-06-23 11:46:08 PDT 
Created attachment 402576 [details]
Patch
Comment 2 Yusuke Suzuki 2020-06-23 11:46:10 PDT 
<rdar://problem/64642067>
Comment 3 Mark Lam 2020-06-23 11:53:30 PDT 
Comment on attachment 402576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Clobberize misses `write(World)` report in some nodes

write(Heap).

> Source/JavaScriptCore/ChangeLog:9
> +        In some DFG nodes, clobberize phase misses `clobberTopFunctor` call while it is `write(World)`,

You mean `write(Heap)`, right?
Comment 4 Yusuke Suzuki 2020-06-23 11:55:28 PDT 
Comment on attachment 402576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] Clobberize misses `write(World)` report in some nodes
> 
> write(Heap).

Right.

>> Source/JavaScriptCore/ChangeLog:9
>> +        In some DFG nodes, clobberize phase misses `clobberTopFunctor` call while it is `write(World)`,
> 
> You mean `write(Heap)`, right?

Right, fixed. Thanks!
Comment 5 Yusuke Suzuki 2020-06-23 11:57:43 PDT 
Created attachment 402577 [details]
Patch for landing
Comment 6 Yusuke Suzuki 2020-06-23 11:59:44 PDT 
Created attachment 402579 [details]
Patch for landing
Comment 7 EWS 2020-06-24 01:08:48 PDT 
Committed r263445: <https://trac.webkit.org/changeset/263445>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402579 [details].
Comment 8 Yusuke Suzuki 2020-06-24 03:39:43 PDT 
I'll use this bug shortly for webkitbot real test. Revert patch will be created, but it should be unrelated.
Comment 9 Yusuke Suzuki 2020-06-24 03:40:25 PDT 
Re-opened since this is blocked by bug 213551
Comment 10 Yusuke Suzuki 2020-06-24 03:41:08 PDT 
OK, cool. Worked perfectly.