RESOLVED FIXED 213525
[JSC] Clobberize misses `write(Heap)` report in some nodes 
https://bugs.webkit.org/show_bug.cgi?id=213525
Summary [JSC] Clobberize misses `write(Heap)` report in some nodes
Yusuke Suzuki
Reported 2020-06-23 11:44:46 PDT
[JSC] Clobberize misses `write(World)` report in some nodes
Attachments
Patch (3.95 KB, patch)
2020-06-23 11:46 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch for landing (3.94 KB, patch)
2020-06-23 11:57 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.93 KB, patch)
2020-06-23 11:59 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-06-23 11:46:08 PDT
Created attachment 402576 [details] Patch
Yusuke Suzuki
Comment 2 2020-06-23 11:46:10 PDT
<rdar://problem/64642067>
Mark Lam
Comment 3 2020-06-23 11:53:30 PDT
Comment on attachment 402576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Clobberize misses `write(World)` report in some nodes write(Heap). > Source/JavaScriptCore/ChangeLog:9 > + In some DFG nodes, clobberize phase misses `clobberTopFunctor` call while it is `write(World)`, You mean `write(Heap)`, right?
Yusuke Suzuki
Comment 4 2020-06-23 11:55:28 PDT
Comment on attachment 402576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Clobberize misses `write(World)` report in some nodes > > write(Heap). Right. >> Source/JavaScriptCore/ChangeLog:9 >> + In some DFG nodes, clobberize phase misses `clobberTopFunctor` call while it is `write(World)`, > > You mean `write(Heap)`, right? Right, fixed. Thanks!
Yusuke Suzuki
Comment 5 2020-06-23 11:57:43 PDT
Created attachment 402577 [details] Patch for landing
Yusuke Suzuki
Comment 6 2020-06-23 11:59:44 PDT
Created attachment 402579 [details] Patch for landing
EWS
Comment 7 2020-06-24 01:08:48 PDT
Committed r263445: <https://trac.webkit.org/changeset/263445> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402579 [details].
Yusuke Suzuki
Comment 8 2020-06-24 03:39:43 PDT
I'll use this bug shortly for webkitbot real test. Revert patch will be created, but it should be unrelated.
Yusuke Suzuki
Comment 9 2020-06-24 03:40:25 PDT
Re-opened since this is blocked by bug 213551
Yusuke Suzuki
Comment 10 2020-06-24 03:41:08 PDT
OK, cool. Worked perfectly.
Note You need to log in before you can comment on or make changes to this bug.