Bug 213518 - [ews] Allow archiving 'jsc' product
Summary: [ews] Allow archiving 'jsc' product
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-23 08:03 PDT by Diego Pino
Modified: 2020-06-23 12:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2020-06-23 08:03 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (2.71 KB, patch)
2020-06-23 11:40 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-06-23 08:03:05 PDT 
[ews] Allow archiving 'jsc-only' product
Comment 1 Diego Pino 2020-06-23 08:03:37 PDT 
Created attachment 402559 [details]
Patch
Comment 2 Diego Pino 2020-06-23 08:04:59 PDT 
It seems at this moment archiving 'jsc-only' products is not possible. See: https://ews-build.webkit.org/#/builders/38/builds/10

This patch attempts to allow archiving 'jsc-only' products.
Comment 3 Aakash Jain 2020-06-23 08:20:44 PDT 
Comment on attachment 402559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402559&action=review

> Tools/BuildSlaveSupport/built-product-archive:235
> +    elif platform == 'gtk' or platform == 'wpe' or platform == 'jsc-only':

You can also simplify it to: 
elif platform in ('gtk', 'jsc-only', 'wpe'):
Comment 4 Aakash Jain 2020-06-23 09:06:38 PDT 
Please add jsc-only to extractBuiltProduct as well.
Comment 5 Aakash Jain 2020-06-23 09:09:00 PDT 
Maybe we should add support for 'jsc' as well, in case we decide to split up jsc ews queue (in builder and tester) as well.
Comment 6 Diego Pino 2020-06-23 11:40:34 PDT 
Created attachment 402574 [details]
Patch
Comment 7 Aakash Jain 2020-06-23 11:49:08 PDT 
Comment on attachment 402574 [details]
Patch

I am not sure if both 'jsc' and 'jsc-only' should follow same code-path (as wpe/gtk), but that doesn't need to block this patch.
Comment 8 EWS 2020-06-23 12:51:58 PDT 
Committed r263414: <https://trac.webkit.org/changeset/263414>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402574 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-23 12:52:18 PDT 
<rdar://problem/64658577>