Bug 213509 - [WebXR] Fix PlatformXR initialization/destruction
Summary: [WebXR] Fix PlatformXR initialization/destruction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 208988
  Show dependency tree / graph
 
Reported: 2020-06-23 04:50 PDT by Sergio Villar Senin
Modified: 2020-06-24 01:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2020-06-23 05:06 PDT, Sergio Villar Senin 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-06-23 04:50:25 PDT 
[WebXR] Fix PlatformXR initialization/destruction
Comment 1 Sergio Villar Senin 2020-06-23 05:06:30 PDT 
Created attachment 402545 [details]
Patch
Comment 2 youenn fablet 2020-06-23 06:18:54 PDT 
Comment on attachment 402545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218
>              s_instance->m_impl = makeUnique<Impl>();

Can we do this assignment in Instance constructor?
And make m_impl a UniqueRef<> maybe?
Comment 3 Sergio Villar Senin 2020-06-24 01:42:29 PDT 
Comment on attachment 402545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review

Thanks for the review!

>> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218
>>              s_instance->m_impl = makeUnique<Impl>();
> 
> Can we do this assignment in Instance constructor?
> And make m_impl a UniqueRef<> maybe?

Makes total sense.
Comment 4 Sergio Villar Senin 2020-06-24 01:50:13 PDT 
Committed r263447: <https://trac.webkit.org/changeset/263447>
Comment 5 Radar WebKit Bug Importer 2020-06-24 01:51:15 PDT 
<rdar://problem/64690849>