Bug 21350 - WebCoreObjCExtras.c is actually an obj-c++ file
Summary: WebCoreObjCExtras.c is actually an obj-c++ file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-03 15:16 PDT by Jeremy Moskovich
Modified: 2008-10-06 18:10 PDT (History)
2 users (show)

See Also:


Attachments
Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm (13.33 KB, patch)
2008-10-03 15:18 PDT, Jeremy Moskovich
no flags Details | Formatted Diff | Diff
it's->its (13.33 KB, patch)
2008-10-03 15:30 PDT, Jeremy Moskovich
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2008-10-03 15:16:49 PDT
The included wtf/MainThread.h and wtf/Threading.h both contain c++ namespace declarations.
Comment 1 Jeremy Moskovich 2008-10-03 15:18:44 PDT
Created attachment 24072 [details]
Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm

Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm
Comment 2 Dave Hyatt 2008-10-03 15:29:24 PDT
Comment on attachment 24072 [details]
Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm

Typo in changelog:

"it's" should be "its"

r=me
Comment 3 Jeremy Moskovich 2008-10-03 15:30:58 PDT
Created attachment 24073 [details]
it's->its
Comment 4 Eric Seidel (no email) 2008-10-06 18:10:40 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	R	WebCore/platform/mac/WebCoreObjCExtras.c => WebCore/platform/mac/WebCoreObjCExtras.mm
	M	WebCore/ChangeLog
	M	WebCore/WebCore.xcodeproj/project.pbxproj
Committed r37358