Bug 213492 - Web Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `<select>` for listener filtering
Summary: Web Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `<select>`...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-22 15:56 PDT by Devin Rousso
Modified: 2020-06-22 17:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.54 KB, patch)
2020-06-22 15:57 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-22 15:56:21 PDT 
Using a `<select>` means that the context menu will appear in the same place no matter where the icon is clicked, but that is not needed, so just use a `WI.ContextMenu` instead (it's also simpler).
Comment 1 Devin Rousso 2020-06-22 15:57:42 PDT 
Created attachment 402518 [details]
Patch
Comment 2 EWS 2020-06-22 16:43:51 PDT 
Committed r263376: <https://trac.webkit.org/changeset/263376>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402518 [details].
Comment 3 Radar WebKit Bug Importer 2020-06-22 16:44:16 PDT 
<rdar://problem/64614336>
Comment 4 Nikita Vasilyev 2020-06-22 17:34:55 PDT 
From the accessibility point, I think we should go the exact opposite way - use <select> elements instead of WI.ContextMenu on <div> elements whenever possible.

In VoiceOver, when simulating a click by pressing Cmd-Shift-Ctrl-Option-Space, the context menu is shown as expected, but it isn't immediately focused.

Also, with this patch, the filter icon is no longer tab-focusable.