Bug 213475 - [ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabler.Reload are constant failures
Summary: [ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.Sle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-22 12:19 PDT by Jacob Uphoff
Modified: 2020-06-23 09:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2020-06-22 12:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Uphoff 2020-06-22 12:19:07 PDT 
TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabler.Reload

These tests were introduced as constant failures with commit r263321

https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Tests/builds/6502/steps/run-api-tests/logs/stdio

Failed

    TestWebKitAPI.SleepDisabler.Load
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:103
        Expected equality of these values:
          shouldHaveSleepDisabler
            Which is: false
          [webView _hasSleepDisabler]
            Which is: '\x1' (1)
        

    TestWebKitAPI.SleepDisabler.Reload
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:103
        Expected equality of these values:
          shouldHaveSleepDisabler
            Which is: false
          [webView _hasSleepDisabler]
            Which is: '\x1' (1)


https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Tests/builds/6502/steps/run-api-tests/logs/stdio
Comment 1 Radar WebKit Bug Importer 2020-06-22 12:19:34 PDT 
<rdar://problem/64603555>
Comment 2 Jer Noble 2020-06-22 12:43:55 PDT 
Created attachment 402499 [details]
Patch
Comment 3 EWS 2020-06-22 14:55:41 PDT 
Committed r263368: <https://trac.webkit.org/changeset/263368>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402499 [details].
Comment 4 Ryan Haddad 2020-06-23 09:44:48 PDT 
*** Bug 213513 has been marked as a duplicate of this bug. ***