RESOLVED FIXED 213473
resultsdbpy: Make architecture differences explicit
https://bugs.webkit.org/show_bug.cgi?id=213473
Summary resultsdbpy: Make architecture differences explicit
Jonathan Bedard
Reported 2020-06-22 11:54:47 PDT
Architecture used to be implied by platform, so we didn't display it in the UI. This is no longer the case.
Attachments
Patch (1.34 KB, patch)
2020-06-22 12:08 PDT, Jonathan Bedard
no flags
Patch for landing (1.34 KB, patch)
2020-06-22 13:37 PDT, Jonathan Bedard
no flags
Radar WebKit Bug Importer
Comment 1 2020-06-22 11:55:06 PDT
Jonathan Bedard
Comment 2 2020-06-22 12:08:09 PDT
Aakash Jain
Comment 3 2020-06-22 12:12:45 PDT
Comment on attachment 402489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402489&action=review > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:183 > + result += ' with ' + this.architecture; Can you please provide an example of the use-case?
Jonathan Bedard
Comment 4 2020-06-22 13:14:28 PDT
(In reply to Aakash Jain from comment #3) > Comment on attachment 402489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402489&action=review > > > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:183 > > + result += ' with ' + this.architecture; > > Can you please provide an example of the use-case? Mojave E Release on Macmini8,1 with x86_64 This is super important for Rosetta testing because a single model can actually run with multiple architectures.
Aakash Jain
Comment 5 2020-06-22 13:32:34 PDT
Comment on attachment 402489 [details] Patch rs=me
Jonathan Bedard
Comment 6 2020-06-22 13:37:34 PDT
Created attachment 402505 [details] Patch for landing
EWS
Comment 7 2020-06-22 14:53:44 PDT
Committed r263367: <https://trac.webkit.org/changeset/263367> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402505 [details].
Note You need to log in before you can comment on or make changes to this bug.