Bug 213472 - Allow building JavaScriptCore Mac+arm64 in public SDK build
Summary: Allow building JavaScriptCore Mac+arm64 in public SDK build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 213102 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-22 11:54 PDT by Saam Barati
Modified: 2020-08-06 18:02 PDT (History)
20 users (show)

See Also:

Attachments
WIP (24.26 KB, patch)
2020-06-22 12:01 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (24.65 KB, patch)
2020-06-22 13:37 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Patch (30.50 KB, patch)
2020-06-22 15:17 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-06-22 11:54:42 PDT 
...
Comment 1 Saam Barati 2020-06-22 12:01:41 PDT 
Created attachment 402488 [details]
WIP

Let's test EWS. Current patch is a bit old, not even sure it'll apply to ToT still
Comment 2 Saam Barati 2020-06-22 13:37:36 PDT 
Created attachment 402506 [details]
WIP

get it to compile take 2
Comment 3 Saam Barati 2020-06-22 15:17:07 PDT 
Created attachment 402515 [details]
Patch
Comment 4 Sam Weinig 2020-06-22 16:02:04 PDT 
Comment on attachment 402515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402515&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:-163
> -/* FIXME: This should probably be HAVE_FAST_JIT_PERMISSIONS and may be entirely unnecessary due to runtime checking support via os_thread_self_restrict_rwx_is_supported(). */
> -#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK)

Excited to see one of my fixme's being resolved!
Comment 5 Saam Barati 2020-06-22 16:22:43 PDT 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 402515 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402515&action=review
> 
> > Source/WTF/wtf/PlatformEnableCocoa.h:-163
> > -/* FIXME: This should probably be HAVE_FAST_JIT_PERMISSIONS and may be entirely unnecessary due to runtime checking support via os_thread_self_restrict_rwx_is_supported(). */
> > -#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK)
> 
> Excited to see one of my fixme's being resolved!

:-)
Comment 6 EWS 2020-06-22 18:28:22 PDT 
Committed r263380: <https://trac.webkit.org/changeset/263380>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402515 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-22 18:29:18 PDT 
<rdar://problem/64618340>
Comment 8 Jonathan Bedard 2020-06-22 21:32:06 PDT 
This broke the watchOS Simulator build:
https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/builds/69
Comment 9 Saam Barati 2020-06-22 22:04:54 PDT 
(In reply to Jonathan Bedard from comment #8)
> This broke the watchOS Simulator build:
> https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/
> builds/69

Will fix
Comment 10 Saam Barati 2020-06-22 22:28:49 PDT 
attempted fix in:
https://trac.webkit.org/changeset/263385/webkit
Comment 11 Jonathan Bedard 2020-06-23 07:43:27 PDT 
(In reply to Saam Barati from comment #10)
> attempted fix in:
> https://trac.webkit.org/changeset/263385/webkit

Thank you!
Comment 12 Saam Barati 2020-08-06 18:02:02 PDT 
*** Bug 213102 has been marked as a duplicate of this bug. ***