...
Created attachment 402488 [details] WIP Let's test EWS. Current patch is a bit old, not even sure it'll apply to ToT still
Created attachment 402506 [details] WIP get it to compile take 2
Created attachment 402515 [details] Patch
Comment on attachment 402515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402515&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:-163 > -/* FIXME: This should probably be HAVE_FAST_JIT_PERMISSIONS and may be entirely unnecessary due to runtime checking support via os_thread_self_restrict_rwx_is_supported(). */ > -#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK) Excited to see one of my fixme's being resolved!
(In reply to Sam Weinig from comment #4) > Comment on attachment 402515 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402515&action=review > > > Source/WTF/wtf/PlatformEnableCocoa.h:-163 > > -/* FIXME: This should probably be HAVE_FAST_JIT_PERMISSIONS and may be entirely unnecessary due to runtime checking support via os_thread_self_restrict_rwx_is_supported(). */ > > -#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK) > > Excited to see one of my fixme's being resolved! :-)
Committed r263380: <https://trac.webkit.org/changeset/263380> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402515 [details].
<rdar://problem/64618340>
This broke the watchOS Simulator build: https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/builds/69
(In reply to Jonathan Bedard from comment #8) > This broke the watchOS Simulator build: > https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/ > builds/69 Will fix
attempted fix in: https://trac.webkit.org/changeset/263385/webkit
(In reply to Saam Barati from comment #10) > attempted fix in: > https://trac.webkit.org/changeset/263385/webkit Thank you!
*** Bug 213102 has been marked as a duplicate of this bug. ***