Bug 21347 - FormDataStreamMac.mm calls isMainThread without #including <wtf/Threading.h>
Summary: FormDataStreamMac.mm calls isMainThread without #including <wtf/Threading.h>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Mark Mentovai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-03 14:21 PDT by Mark Mentovai
Modified: 2008-10-06 18:11 PDT (History)
2 users (show)

See Also:


Attachments
Adds the appropriate #import (910 bytes, patch)
2008-10-03 14:24 PDT, Mark Mentovai
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Mentovai 2008-10-03 14:21:34 PDT
WebCore/platform/network/mac/FormDataStreamMac.mm calls isMainThread without the #include that declares that function.  This causes a problem when building Chromium.  FormDataStreamMac.mm does include <wtf/MainThread.h>, but that file does not bring in Threading.h or the isMainThread function.
Comment 1 Mark Mentovai 2008-10-03 14:24:02 PDT
Created attachment 24068 [details]
Adds the appropriate #import
Comment 2 Darin Adler 2008-10-03 14:26:25 PDT
Comment on attachment 24068 [details]
Adds the appropriate #import

Why doesn't this break compilation? Is there something different about your configuration?
Comment 3 Mark Mentovai 2008-10-03 14:29:35 PDT
You might be getting it via prefix header injection, although we're using the same prefix header I assume you are, WebCore/WebCorePrefix.h.
Comment 4 Eric Seidel (no email) 2008-10-06 18:11:52 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/network/mac/FormDataStreamMac.mm
Committed r37361