[WebXR] Introducing XRLayer

[Sergio Villar Senin]

[WebXR] Introducing XRLayer

[Sergio Villar Senin]

Created attachment 402484 [details]
Patch

[youenn fablet]

Comment on attachment 402484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402484&action=review

> Source/WebCore/Modules/webxr/WebXRLayer.h:48
> +    WebXRLayer(ScriptExecutionContext*);

explicit and ScriptExecutionContext& or is there a point in supporting nullptr?

> Source/WebCore/Modules/webxr/WebXRLayer.h:51
> +    ScriptExecutionContext* scriptExecutionContext() const override { return ContextDestructionObserver::scriptExecutionContext(); }

final?

> Source/WebCore/Modules/webxr/WebXRLayer.h:57
> +    void derefEventTarget() override { deref(); }

final for all of these?

> Source/WebCore/Modules/webxr/WebXRSession.h:80
> +    ScriptExecutionContext* scriptExecutionContext() const override { return ActiveDOMObject::scriptExecutionContext(); }

final?

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:107
>  WebXRWebGLLayer::WebXRWebGLLayer(WebXRSession& session, WebXRRenderingContext&& context, const XRWebGLLayerInit& init)

Would be best to have a Ref<WebXRSession>&&

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.h:62
> +    virtual ~WebXRWebGLLayer();

Not needed I believe

[Sergio Villar Senin]

Comment on attachment 402484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402484&action=review

Thanks for the review Youenn!

>> Source/WebCore/Modules/webxr/WebXRLayer.h:48
>> +    WebXRLayer(ScriptExecutionContext*);
> 
> explicit and ScriptExecutionContext& or is there a point in supporting nullptr?

OK

>> Source/WebCore/Modules/webxr/WebXRLayer.h:57
>> +    void derefEventTarget() override { deref(); }
> 
> final for all of these?

Ok

>> Source/WebCore/Modules/webxr/WebXRSession.h:80
>> +    ScriptExecutionContext* scriptExecutionContext() const override { return ActiveDOMObject::scriptExecutionContext(); }
> 
> final?

Ok

>> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:107
>>  WebXRWebGLLayer::WebXRWebGLLayer(WebXRSession& session, WebXRRenderingContext&& context, const XRWebGLLayerInit& init)
> 
> Would be best to have a Ref<WebXRSession>&&

Ok.

>> Source/WebCore/Modules/webxr/WebXRWebGLLayer.h:62
>> +    virtual ~WebXRWebGLLayer();
> 
> Not needed I believe

Indeed.

[Sergio Villar Senin]

Committed r263403: <https://trac.webkit.org/changeset/263403>

[Radar WebKit Bug Importer]

<rdar://problem/64648039>