Bug 213450 – [WTF] URL should support dataLog

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[WTF] URL should support dataLog

[Yusuke Suzuki]

Created attachment 402439 [details]
Patch

[Yusuke Suzuki]

Created attachment 402440 [details]
Patch

[Yusuke Suzuki]

Created attachment 402441 [details]
Patch

[Yusuke Suzuki]

I need to admit that we should eventually merge TextStream (WebCore side thing) and PrintStream (WTF / JSC side thing) into one, but it requires a grand plan anyway :)

[Mark Lam]

Comment on attachment 402441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review

r=me with nit.

> Source/WTF/wtf/URL.cpp:770
> +void URL::dump(PrintStream& out) const
> +{
> +    out.print(m_string);
> +}

nit: should we keep this definition in the header instead?  If it's not normally used and we only need this for occasional debugging use, then it is more efficient to have it in the header vs explicitly putting it here.  There a lot of other less commonly dumped data structures that do this also.

[Yusuke Suzuki]

Comment on attachment 402441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review

>> Source/WTF/wtf/URL.cpp:770
>> +}
> 
> nit: should we keep this definition in the header instead?  If it's not normally used and we only need this for occasional debugging use, then it is more efficient to have it in the header vs explicitly putting it here.  There a lot of other less commonly dumped data structures that do this also.

Discussed with Mark on Slack. We keep it as is to avoid including `#include <wtf/PrintStream.h>` in `URL.h`.

[EWS]

Committed r263340: <https://trac.webkit.org/changeset/263340>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402441 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64585651>