Bug 213437 - RecoveryOS: PAL::getAVPlayerLayerClass() will crash when AVFoundation is missing
Summary: RecoveryOS: PAL::getAVPlayerLayerClass() will crash when AVFoundation is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-20 14:00 PDT by Jer Noble
Modified: 2020-06-20 19:49 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2020-06-20 14:04 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (6.19 KB, patch)
2020-06-20 18:00 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-06-20 14:00:00 PDT 
RecoveryOS: PAL::getAVPlayerLayerClass() will crash when AVFoundation is missing
Comment 1 Radar WebKit Bug Importer 2020-06-20 14:02:15 PDT 
<rdar://problem/64563064>
Comment 2 Jer Noble 2020-06-20 14:04:16 PDT 
Created attachment 402401 [details]
Patch
Comment 3 Peng Liu 2020-06-20 14:18:51 PDT 
Comment on attachment 402401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402401&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:1281
> +    if (PAL::isAVFoundationFrameworkAvailable())

Seems incorrect?
Comment 4 Eric Carlson 2020-06-20 14:46:46 PDT 
Comment on attachment 402401 [details]
Patch

r=me with the issue Peng point out changed
Comment 5 Jer Noble 2020-06-20 18:00:53 PDT 
Created attachment 402411 [details]
Patch for landing
Comment 6 Jer Noble 2020-06-20 18:11:02 PDT 
(In reply to Peng Liu from comment #3)
> Comment on attachment 402401 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402401&action=review
> 
> > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:1281
> > +    if (PAL::isAVFoundationFrameworkAvailable())
> 
> Seems incorrect?

Good catch!
Comment 7 EWS 2020-06-20 19:49:31 PDT 
Committed r263323: <https://trac.webkit.org/changeset/263323>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402411 [details].