Bug 213434 – REGRESSION(r259219): Sleep assertion remains active if WKWebView is closed or WebContent process crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

REGRESSION(r259219): Sleep assertion remains active if WKWebView is closed or WebContent process crashes

[Jer Noble]

<rdar://problem/57541662>

[Jer Noble]

Created attachment 402398 [details]
Patch

[Jer Noble]

Created attachment 402399 [details]
Patch

[Eric Carlson]

Comment on attachment 402399 [details]
Patch

Maybe check to be sure there is no sleep disabler at the beginning of each test to ensure that the one from the previous test was released?

[Jer Noble]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 402399 [details]
> Patch
> 
> Maybe check to be sure there is no sleep disabler at the beginning of each
> test to ensure that the one from the previous test was released?

Querying for Sleep Disabling (for testing purposes at least) is per WKWebView, and we create a new WKWebView for every test. So this would be a no-op, I'm afraid.

[EWS]

Committed r263321: <https://trac.webkit.org/changeset/263321>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402399 [details].

[Chris Dumez]

Comment on attachment 402399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402399&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:859
> +    m_sleepDisablers.clear();

This seems redundant since processDidTerminateOrFailedToLaunch() calls shutDown().