Bug 213426 - WebKit fails to leave audio routing arbitration during navigation, closing.
Summary: WebKit fails to leave audio routing arbitration during navigation, closing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-20 00:26 PDT by Jer Noble
Modified: 2020-06-22 00:19 PDT (History)
13 users (show)

See Also:

Attachments
Patch (21.72 KB, patch)
2020-06-20 00:38 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (22.08 KB, patch)
2020-06-20 18:06 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-06-20 00:26:24 PDT 
WebKit fails to leave audio routing arbitration during navigation, closing.
Comment 1 Jer Noble 2020-06-20 00:27:37 PDT 
<rdar://problem/64395051>
Comment 2 Radar WebKit Bug Importer 2020-06-20 00:27:52 PDT 
<rdar://problem/64556258>
Comment 3 Jer Noble 2020-06-20 00:38:56 PDT 
Created attachment 402378 [details]
Patch
Comment 4 Jer Noble 2020-06-20 00:39:21 PDT 
<rdar://problem/64395051>
Comment 5 Eric Carlson 2020-06-20 14:41:13 PDT 
Comment on attachment 402378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402378&action=review

Is it worth adding a test that deletes the <video> element?

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:245
> +    case WebKit::AudioSessionRoutingArbitratorProxy::ArbitrationStatus::None:return WKWebViewAudioRoutingArbitrationStatusNone;

Nit: missing a space before "return"
Comment 6 Jer Noble 2020-06-20 18:02:50 PDT 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 402378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402378&action=review
> 
> Is it worth adding a test that deletes the <video> element?

Might as well!

> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:245
> > +    case WebKit::AudioSessionRoutingArbitratorProxy::ArbitrationStatus::None:return WKWebViewAudioRoutingArbitrationStatusNone;
> 
> Nit: missing a space before "return"

Fixed.
Comment 7 Jer Noble 2020-06-20 18:06:59 PDT 
Created attachment 402412 [details]
Patch for landing
Comment 8 EWS 2020-06-21 08:34:18 PDT 
Committed r263328: <https://trac.webkit.org/changeset/263328>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402412 [details].
Comment 9 Antoine Quint 2020-06-22 00:19:05 PDT 
Committed r263342: <https://trac.webkit.org/changeset/263342>