Bug 213423 - [Apple Pay] WebPaymentCoordinatorProxy can be destroyed without dismissing its authorization presenter
Summary: [Apple Pay] WebPaymentCoordinatorProxy can be destroyed without dismissing it...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-19 19:14 PDT by Andy Estes
Modified: 2020-06-23 15:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.45 KB, patch)
2020-06-20 10:26 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (23.17 KB, patch)
2020-06-20 10:44 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (24.01 KB, patch)
2020-06-20 10:55 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (23.98 KB, patch)
2020-06-23 15:24 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2020-06-19 19:14:21 PDT Comment hidden (obsolete)
Comment 1 Andy Estes 2020-06-19 19:16:29 PDT 
rdar://problem/60416221
Comment 2 Andy Estes 2020-06-20 10:26:44 PDT Comment hidden (obsolete)
Comment 3 Andy Estes 2020-06-20 10:44:55 PDT Comment hidden (obsolete)
Comment 4 Andy Estes 2020-06-20 10:55:04 PDT 
Created attachment 402392 [details]
Patch
Comment 5 youenn fablet 2020-06-23 06:32:33 PDT 
Comment on attachment 402392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402392&action=review

> Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:318
> +        send(Messages::WebPaymentCoordinator::DidCancelPaymentSession(WTFMove(error)));

No need for WTFMove, DidCancelPaymentSession is probably taking a const&
Comment 6 Andy Estes 2020-06-23 15:24:46 PDT 
Created attachment 402597 [details]
Patch
Comment 7 EWS 2020-06-23 15:47:59 PDT 
Committed r263426: <https://trac.webkit.org/changeset/263426>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402597 [details].