WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
213414
[Cocoa] Delay issuing ManagedSession & Network Extension sandbox extensions until a load is actually issued
https://bugs.webkit.org/show_bug.cgi?id=213414
Summary
[Cocoa] Delay issuing ManagedSession & Network Extension sandbox extensions u...
Chris Dumez
Reported
2020-06-19 16:22:22 PDT
Delay issuing ManagedSession & Network Extension sandbox extensions until a load is actually issued.
Attachments
Patch
(28.12 KB, patch)
2020-06-19 16:54 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(28.16 KB, patch)
2020-06-19 17:12 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(28.22 KB, patch)
2020-06-19 17:22 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(28.22 KB, patch)
2020-06-19 17:37 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(27.95 KB, patch)
2020-06-19 19:03 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(27.95 KB, patch)
2020-06-19 19:46 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-06-19 16:22:40 PDT
<
rdar://problem/64548684
>
Chris Dumez
Comment 2
2020-06-19 16:54:00 PDT
Created
attachment 402349
[details]
Patch
Per Arne Vollan
Comment 3
2020-06-19 17:07:24 PDT
Comment on
attachment 402349
[details]
Patch R=me, after fixing compile issue.
Chris Dumez
Comment 4
2020-06-19 17:12:58 PDT
Created
attachment 402353
[details]
Patch
Per Arne Vollan
Comment 5
2020-06-19 17:19:12 PDT
Comment on
attachment 402353
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=402353&action=review
> Source/WebKit/UIProcess/WebProcessProxy.h:588 > + bool m_hasNetworkExtensionSandboxAccess { false };
Should this be inside #if PLATFORM(COCOA)?
Chris Dumez
Comment 6
2020-06-19 17:20:47 PDT
(In reply to Per Arne Vollan from
comment #5
)
> Comment on
attachment 402353
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=402353&action=review
> > > Source/WebKit/UIProcess/WebProcessProxy.h:588 > > + bool m_hasNetworkExtensionSandboxAccess { false }; > > Should this be inside #if PLATFORM(COCOA)?
Oh right. I will add it.
Chris Dumez
Comment 7
2020-06-19 17:22:29 PDT
Created
attachment 402356
[details]
Patch
Chris Dumez
Comment 8
2020-06-19 17:37:29 PDT
Created
attachment 402362
[details]
Patch
EWS
Comment 9
2020-06-19 18:42:31 PDT
Tools/Scripts/svn-apply failed to apply
attachment 402362
[details]
to trunk. Please resolve the conflicts and upload a new patch.
Chris Dumez
Comment 10
2020-06-19 19:03:49 PDT
Created
attachment 402368
[details]
Patch
EWS
Comment 11
2020-06-19 19:37:46 PDT
Patch 402368 does not build
Chris Dumez
Comment 12
2020-06-19 19:46:12 PDT
Created
attachment 402372
[details]
Patch
EWS
Comment 13
2020-06-19 20:50:15 PDT
Committed
r263313
: <
https://trac.webkit.org/changeset/263313
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 402372
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug