Bug 213414 - [Cocoa] Delay issuing ManagedSession & Network Extension sandbox extensions until a load is actually issued
Summary: [Cocoa] Delay issuing ManagedSession & Network Extension sandbox extensions u...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-19 16:22 PDT by Chris Dumez
Modified: 2020-06-19 20:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (28.12 KB, patch)
2020-06-19 16:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.16 KB, patch)
2020-06-19 17:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.22 KB, patch)
2020-06-19 17:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.22 KB, patch)
2020-06-19 17:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.95 KB, patch)
2020-06-19 19:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.95 KB, patch)
2020-06-19 19:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-06-19 16:22:22 PDT 
Delay issuing ManagedSession & Network Extension sandbox extensions until a load is actually issued.
Comment 1 Radar WebKit Bug Importer 2020-06-19 16:22:40 PDT 
<rdar://problem/64548684>
Comment 2 Chris Dumez 2020-06-19 16:54:00 PDT 
Created attachment 402349 [details]
Patch
Comment 3 Per Arne Vollan 2020-06-19 17:07:24 PDT 
Comment on attachment 402349 [details]
Patch

R=me, after fixing compile issue.
Comment 4 Chris Dumez 2020-06-19 17:12:58 PDT 
Created attachment 402353 [details]
Patch
Comment 5 Per Arne Vollan 2020-06-19 17:19:12 PDT 
Comment on attachment 402353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402353&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:588
> +    bool m_hasNetworkExtensionSandboxAccess { false };

Should this be inside #if PLATFORM(COCOA)?
Comment 6 Chris Dumez 2020-06-19 17:20:47 PDT 
(In reply to Per Arne Vollan from comment #5)
> Comment on attachment 402353 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402353&action=review
> 
> > Source/WebKit/UIProcess/WebProcessProxy.h:588
> > +    bool m_hasNetworkExtensionSandboxAccess { false };
> 
> Should this be inside #if PLATFORM(COCOA)?

Oh right. I will add it.
Comment 7 Chris Dumez 2020-06-19 17:22:29 PDT 
Created attachment 402356 [details]
Patch
Comment 8 Chris Dumez 2020-06-19 17:37:29 PDT 
Created attachment 402362 [details]
Patch
Comment 9 EWS 2020-06-19 18:42:31 PDT 
Tools/Scripts/svn-apply failed to apply attachment 402362 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 Chris Dumez 2020-06-19 19:03:49 PDT 
Created attachment 402368 [details]
Patch
Comment 11 EWS 2020-06-19 19:37:46 PDT 
Patch 402368 does not build
Comment 12 Chris Dumez 2020-06-19 19:46:12 PDT 
Created attachment 402372 [details]
Patch
Comment 13 EWS 2020-06-19 20:50:15 PDT 
Committed r263313: <https://trac.webkit.org/changeset/263313>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402372 [details].