Bug 213411 – Web Inspector: do not report data on the rejected intercepted CORS request

• Status: NEW
• Component: Web Inspector

[Pavel Feldman]

Resource can become disregarded right after the call to `didReceiveResponse`. Do not report received buffer and loading finished to such request.

[Pavel Feldman]

Created attachment 402339 [details]
Patch

[Devin Rousso]

Comment on attachment 402339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402339&action=review

r=me

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:1295
> +            return;

Style: please add a newline after this `return`

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:12
> +        let response = await fetch("http://localhost:8000/data", { mode: "cors" });

Style: no space after `{` or before `}` when inlined

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:15
> +        return { error: e.message };

Ditto (:12)

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:21
> +    InspectorTest.debug();

oops

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:58
> +        name: "Network.interceptRequestWithResponse.CORS allow origin",

NIT: we usually don't use spaces in test case names, preferring camel casing and periods.
```
    name: "Network.interceptRequestWithResponse.CORS.Origin.Allow",
```

> LayoutTests/http/tests/inspector/network/intercept-cors-request.html:66
> +        name: "Network.interceptRequestWithResponse.CORS disallow origin",

Ditto (:58)
```
    name: "Network.interceptRequestWithResponse.CORS.Origin.Disallow",
```