RESOLVED FIXED 213409
Remove unnecessary Timer from NetworkDataTask 
https://bugs.webkit.org/show_bug.cgi?id=213409
Summary Remove unnecessary Timer from NetworkDataTask
Alex Christensen
Reported 2020-06-19 15:06:49 PDT
Remove unnecessary Timer from NetworkDataTask
Attachments
Patch (6.89 KB, patch)
2020-06-19 15:09 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2020-06-23 11:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-19 15:09:52 PDT
Created attachment 402332 [details] Patch
youenn fablet
Comment 2 2020-06-23 06:27:30 PDT
Comment on attachment 402332 [details] Patch Please make sure to fix GTK/WPE/WIN
Alex Christensen
Comment 3 2020-06-23 11:03:50 PDT
Created attachment 402570 [details] Patch
EWS
Comment 4 2020-06-23 11:41:13 PDT
Committed r263407: <https://trac.webkit.org/changeset/263407> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402570 [details].
Radar WebKit Bug Importer
Comment 5 2020-06-23 11:42:16 PDT
<rdar://problem/64654646>
Darin Adler
Comment 6 2020-06-23 12:21:42 PDT
Comment on attachment 402570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review > Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100 > + if (!weakThis || !m_client) > + return; Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread?
Alex Christensen
Comment 7 2020-06-23 13:58:00 PDT
Comment on attachment 402570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review >> Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100 >> + return; > > Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread? NetworkDataTask is always destroyed on the main thread because it uses WTF::DestructionThread::Main
Note You need to log in before you can comment on or make changes to this bug.