Remove unnecessary Timer from NetworkDataTask
Created attachment 402332 [details] Patch
Comment on attachment 402332 [details] Patch Please make sure to fix GTK/WPE/WIN
Created attachment 402570 [details] Patch
Committed r263407: <https://trac.webkit.org/changeset/263407> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402570 [details].
<rdar://problem/64654646>
Comment on attachment 402570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review > Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100 > + if (!weakThis || !m_client) > + return; Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread?
Comment on attachment 402570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402570&action=review >> Source/WebKit/NetworkProcess/NetworkDataTask.cpp:100 >> + return; > > Is this a safe idiom? Do we have a guarantee that we are not racing with a deref of NetworkDataTask on another thread? NetworkDataTask is always destroyed on the main thread because it uses WTF::DestructionThread::Main