Bug 213408 - [AutoSizing] Resolve viewport units against the preferred content size
Summary: [AutoSizing] Resolve viewport units against the preferred content size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
: 213313 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-19 14:56 PDT by zalan
Modified: 2020-06-19 19:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.25 KB, patch)
2020-06-19 15:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.25 KB, patch)
2020-06-19 15:30 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.86 KB, patch)
2020-06-19 17:21 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-06-19 14:56:45 PDT 
<rdar://problem/64267539>
Comment 1 zalan 2020-06-19 14:59:45 PDT 
*** Bug 213313 has been marked as a duplicate of this bug. ***
Comment 2 zalan 2020-06-19 15:14:47 PDT 
Created attachment 402333 [details]
Patch
Comment 3 Tim Horton 2020-06-19 15:26:10 PDT 
Comment on attachment 402333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402333&action=review

> Source/WebCore/ChangeLog:19
> +        and resolved the values against the horiztonal constraint).

horiztonal

> Source/WebCore/testing/Internals.cpp:3716
> +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int height)

We already have tests. Maybe no internals method because they’re all API tests? OK
Comment 4 zalan 2020-06-19 15:30:20 PDT 
Created attachment 402336 [details]
Patch
Comment 5 zalan 2020-06-19 15:31:59 PDT 
> > Source/WebCore/testing/Internals.cpp:3716
> > +void Internals::enableSizeToContentAutoSizeMode(bool enabled, int width, int height)
> 
> We already have tests. Maybe no internals method because they’re all API
> tests? OK
Yeah, and we already have layout tests for the fixed-autosizing(mail), so I thought why not add one for the contentsize-autosizing.
Comment 6 zalan 2020-06-19 17:21:24 PDT 
Created attachment 402354 [details]
Patch
Comment 7 EWS 2020-06-19 17:57:40 PDT 
commit-queue failed to commit attachment 402354 [details] to WebKit repository.
Comment 8 zalan 2020-06-19 19:45:00 PDT 
Committed r263311: <https://trac.webkit.org/changeset/263311>