Bug 213399 - [WPE][GTK] Add autocleanup for WebKitWebsitePolicies
Summary: [WPE][GTK] Add autocleanup for WebKitWebsitePolicies
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2020-06-19 12:38 PDT by Michael Catanzaro
Modified: 2020-06-21 02:11 PDT (History)
7 users (show)

See Also:

Patch (2.42 KB, patch)
2020-06-19 12:39 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-06-19 12:38:08 PDT
We forgot to add an autocleanup for WebKitWebsitePolicies.

If we were to switch to G_DECLARE_[FINAL,DERIVABLE]_TYPE for the GTK 4 API, then we wouldn't have to remember to do these manually anymore. ;)
Comment 1 Michael Catanzaro 2020-06-19 12:39:27 PDT
Created attachment 402306 [details]
Comment 2 EWS Watchlist 2020-06-19 12:40:05 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Charlie Turner 2020-06-19 13:17:13 PDT
LGTM (not a formal reviewer sadly). Thanks for taking care of it!
Comment 4 Carlos Garcia Campos 2020-06-21 02:08:23 PDT
Comment on attachment 402306 [details]

I always forget autoclean. Thanks!
Comment 5 EWS 2020-06-21 02:11:08 PDT
Committed r263325: <https://trac.webkit.org/changeset/263325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402306 [details].