Bug 213396 - [iOS] RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID()
Summary: [iOS] RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-19 11:52 PDT by Chris Dumez
Modified: 2020-06-19 13:13 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2020-06-19 12:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2020-06-19 12:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-06-19 11:52:11 PDT 
RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID().
cssValueToSystemColorMap() already has the selector, yet it passes a CSSValueID to systemColorFromCSSValueID() which then does a linear search to match the CSSValueID to a selector.
Comment 1 Chris Dumez 2020-06-19 12:09:37 PDT 
Created attachment 402303 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-06-19 12:11:12 PDT 
<rdar://problem/64540057>
Comment 3 Chris Dumez 2020-06-19 12:17:26 PDT 
Created attachment 402304 [details]
Patch
Comment 4 EWS 2020-06-19 13:13:19 PDT 
Committed r263282: <https://trac.webkit.org/changeset/263282>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402304 [details].