Bug 213395 - Make $vm properties non-configurable, non-enumerable, and non-writable.
Summary: Make $vm properties non-configurable, non-enumerable, and non-writable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-19 11:41 PDT by Mark Lam
Modified: 2020-06-23 12:00 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (4.41 KB, patch)
2020-06-19 11:43 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
patch for landing. (6.61 KB, patch)
2020-06-19 13:55 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-06-19 11:41:12 PDT 
...
Comment 1 Mark Lam 2020-06-19 11:43:30 PDT 
Created attachment 402300 [details]
proposed patch.
Comment 2 Saam Barati 2020-06-19 11:59:17 PDT 
Comment on attachment 402300 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=402300&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Make $vm properties non-configurable, non-enumerable, and non-writable.

say why
Comment 3 Yusuke Suzuki 2020-06-19 12:01:49 PDT 
Comment on attachment 402300 [details]
proposed patch.

r=me. Can we have a test that ensures Object.keys for $vm does not contain interesting keys?
Comment 4 Mark Lam 2020-06-19 13:55:12 PDT 
Created attachment 402320 [details]
patch for landing.
Comment 5 Mark Lam 2020-06-19 14:01:05 PDT 
Thanks for the reviews.  Landed in r263283: <http://trac.webkit.org/r263283>.
Comment 6 Radar WebKit Bug Importer 2020-06-19 14:02:17 PDT 
<rdar://problem/64544350>
Comment 7 Radar WebKit Bug Importer 2020-06-19 14:02:17 PDT 
<rdar://problem/64544351>
Comment 8 Mark Lam 2020-06-23 11:09:26 PDT 
<rdar://problem/64544350>
Comment 9 Keith Miller 2020-06-23 12:00:26 PDT 
Why don't we just freeze $vm?