Bug 213377 - Improve handling of trac downtime by commit-queue
Summary: Improve handling of trac downtime by commit-queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-19 07:46 PDT by Aakash Jain
Modified: 2020-06-22 07:08 PDT (History)
12 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2020-06-19 07:51 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-06-19 07:46:11 PDT
We should improve the handling of trac downtime by commit-queue. Yesterday trac was down for some time. Meanwhile commit-queue failed to fetch commiters information from trac, and the commit-queue builds failed. e.g.: https://ews-build.webkit.org/#/builders/28/builds/2774

In such case, commit-queue should try to load the local copy of contributors.json from disk (local checkout).
Comment 1 Aakash Jain 2020-06-19 07:51:28 PDT
Created attachment 402283 [details]
Patch
Comment 2 Aakash Jain 2020-06-19 07:53:50 PDT
cc'ed few people for visibility whose patches failed to land by commit-queue yesterday due to trac downtime.
Comment 3 EWS 2020-06-19 08:31:15 PDT
Committed r263267: <https://trac.webkit.org/changeset/263267>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402283 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-19 08:32:52 PDT
<rdar://problem/64532488>
Comment 5 Alexey Proskuryakov 2020-06-19 09:43:09 PDT
Good idea!
Comment 6 Yusuke Suzuki 2020-06-19 12:35:06 PDT
I have one suggestion: how about getting contributors.json from https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json instead of accessing through trac?
It is not involving trac. So I noticed that the above URL was alive during trac is down.
Several services are using the above URL, https://webkit.org/team and Tools/WKR slackbot.
I think the above one is accessible so long as SVN server is alive, maybe more robust than trac...?
Comment 7 Aakash Jain 2020-06-22 05:27:27 PDT
(In reply to Yusuke Suzuki from comment #6)
> I have one suggestion: how about getting contributors.json from https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json instead of accessing through trac?
Doing it in Bug 213457.
Comment 8 Yusuke Suzuki 2020-06-22 07:08:18 PDT
(In reply to Aakash Jain from comment #7)
> (In reply to Yusuke Suzuki from comment #6)
> > I have one suggestion: how about getting contributors.json from https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json instead of accessing through trac?
> Doing it in Bug 213457.

Nice!