https://wpt.fyi/results/FileAPI/blob/Blob-slice.html?label=experimental&label=master&aligned
Created attachment 402274 [details] Patch
Probably just need to update the mac test and results for http/tests/local/fileapi/send-sliced-dragged-file.html by hand.
Sam, thank you advice!
Created attachment 402426 [details] Patch I addressed failures on mac-wk1
Comment on attachment 402426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402426&action=review > Source/WebCore/fileapi/Blob.idl:45 > + Blob slice(optional long long start = 0, > + optional long long end = 0x7FFFFFFFFFFFFFFF, > + optional DOMString contentType = ""); My preferences would be to not format like this -- in WebKit we normally don’t intent to line up with open parenthesis and it seems we could leave this as a long line. That would have the advantage of having an easy to read diff. But maybe this is just pasted from the specification text?
(In reply to Darin Adler from comment #5) > Comment on attachment 402426 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402426&action=review > > > Source/WebCore/fileapi/Blob.idl:45 > > + Blob slice(optional long long start = 0, > > + optional long long end = 0x7FFFFFFFFFFFFFFF, > > + optional DOMString contentType = ""); > > My preferences would be to not format like this -- in WebKit we normally > don’t intent to line up with open parenthesis and it seems we could leave > this as a long line. That would have the advantage of having an easy to read > diff. But maybe this is just pasted from the specification text? Yes. Certainly, I tweaked a indent a bit but I copied from the spec basically. https://w3c.github.io/FileAPI/#blob-section
Created attachment 402471 [details] Patch I addressed the review point about an indent in idl file
Thank you, Darin!
Committed r263353: <https://trac.webkit.org/changeset/263353> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402471 [details].
<rdar://problem/64598895>