WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
213366
[ews] Add JSC-Only builders for MIPS and ARMv7 architectures
https://bugs.webkit.org/show_bug.cgi?id=213366
Summary
[ews] Add JSC-Only builders for MIPS and ARMv7 architectures
Diego Pino
Reported
2020-06-18 21:49:11 PDT
[ews] Add JSC-Only builders for MIPS and ARMv7 architectures
Attachments
Patch
(8.38 KB, patch)
2020-06-18 21:51 PDT
,
Diego Pino
no flags
Details
Formatted Diff
Diff
Patch
(8.46 KB, patch)
2020-06-19 01:35 PDT
,
Diego Pino
no flags
Details
Formatted Diff
Diff
Patch
(8.39 KB, patch)
2020-06-22 12:33 PDT
,
Diego Pino
no flags
Details
Formatted Diff
Diff
Patch
(8.43 KB, patch)
2020-06-22 13:02 PDT
,
Diego Pino
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Diego Pino
Comment 1
2020-06-18 21:51:19 PDT
Created
attachment 402268
[details]
Patch
Diego Pino
Comment 2
2020-06-19 01:35:33 PDT
Created
attachment 402269
[details]
Patch
Aakash Jain
Comment 3
2020-06-22 05:13:17 PDT
Comment on
attachment 402269
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=402269&action=review
r+ with minor changes.
> Tools/BuildSlaveSupport/ews-build/config.json:479 > + "name": "JSC-Build-MIPSEL-32bits-EWS",
Let's rename this to JSC-MIPSEL-32bits-Build-EWS to match with other builders.
> Tools/BuildSlaveSupport/ews-build/config.json:500 > + "name": "JSC-Build-ARMv7-32bits-EWS",
Let's rename this to JSC-ARMv7-32bits-Build-EWS to match with other builders.
> Tools/BuildSlaveSupport/ews-build/factories.py:140 > class JSCTestsFactory(Factory):
Let's rename this to JSCBuildAndTestsFactory (maybe in separate patch).
Diego Pino
Comment 4
2020-06-22 12:33:06 PDT
Created
attachment 402490
[details]
Patch
Diego Pino
Comment 5
2020-06-22 13:02:15 PDT
Created
attachment 402504
[details]
Patch
EWS
Comment 6
2020-06-22 22:04:59 PDT
Committed
r263384
: <
https://trac.webkit.org/changeset/263384
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 402504
[details]
.
Radar WebKit Bug Importer
Comment 7
2020-06-22 22:05:17 PDT
<
rdar://problem/64624871
>
Aakash Jain
Comment 8
2020-06-23 04:23:17 PDT
Restarted EWS server to pick up this change.
Aakash Jain
Comment 9
2020-06-23 05:06:09 PDT
Minor follow-up fix:
https://trac.webkit.org/changeset/263392/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug