Remove setVelocity() from PannerNode

[Clark Wang]

Removed velocity from PannerNode

[Clark Wang]

Created attachment 402253 [details]
Patch

[Chris Dumez]

Comment on attachment 402253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402253&action=review

> Source/WebCore/ChangeLog:8
> +        Re-baselined previous test that now passes with velocity removed.

Changelog is missing an explanation of the change and a link to the relevant spec section.

[Darin Adler]

Comment on attachment 402253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402253&action=review

> Source/WebCore/Modules/webaudio/PannerNode.cpp:307
> +        const FloatPoint3D& sourceVelocity = FloatPoint3D(0, 0, 0);

This seems a peculiar way to write this. Not even sure it has defined behavior. I think the FloatPoint3D object may be destroyed and the end of the full expression?

Maybe this should just be:

    const FloatPoint32 listenerVelocity;

But of course, this is also a constant that’s always zero and so we could simplify the code below.

[Clark Wang]

Created attachment 402289 [details]
Patch

[EWS]

Committed r263304: <https://trac.webkit.org/changeset/263304>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402289 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64551041>