Bug 213351 - [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
Summary: [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-18 13:35 PDT by Karl Rackler
Modified: 2020-06-23 08:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.47 KB, patch)
2020-06-18 16:24 PDT, Karl Rackler
no flags Details | Formatted Diff | Diff
Patch (5.98 KB, patch)
2020-06-21 17:51 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
For landing (5.93 KB, patch)
2020-06-21 18:07 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (10.69 KB, patch)
2020-06-22 21:18 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (10.88 KB, patch)
2020-06-22 21:23 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Rackler 2020-06-18 13:35:42 PDT
fast/events/platform-wheelevent-in-scrolling-div.html

We are seeing this test failing on Catalina WK2.  Infrequent failure.  We are seeing once every one to two days.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fplatform-wheelevent-in-scrolling-div.html


Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fast/events/platform-wheelevent-in-scrolling-div-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fast/events/platform-wheelevent-in-scrolling-div-actual.txt
@@ -1,6 +1,3 @@
-PASS event.wheelDeltaY is window.expectedScrollTop*-120
-PASS event.wheelDeltaX is window.expectedScrollLeft*-120
-PASS event.wheelDelta is window.expectedScrollTop*-120
-PASS div.scrollTop is window.expectedScrollTop*window.pixelsPerWheelTick
-PASS div.scrollLeft is window.expectedScrollLeft*window.pixelsPerWheelTick
+FAIL div.scrollTop should be 200. Was 0.
+FAIL div.scrollLeft should be 120. Was 0.
Comment 1 Radar WebKit Bug Importer 2020-06-18 13:36:51 PDT
<rdar://problem/64502429>
Comment 2 Karl Rackler 2020-06-18 15:54:48 PDT
Unable to reproduce this failure locally using run-webkit-test.
Comment 3 Karl Rackler 2020-06-18 16:24:20 PDT
Created attachment 402248 [details]
Patch
Comment 4 Truitt Savell 2020-06-18 16:28:10 PDT
Comment on attachment 402248 [details]
Patch

Clearing flags on attachment: 402248

Committed r263244: <https://trac.webkit.org/changeset/263244>
Comment 5 Truitt Savell 2020-06-18 16:28:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Truitt Savell 2020-06-18 16:29:05 PDT
Reopening after landing test expectations
Comment 7 Simon Fraser (smfr) 2020-06-21 17:51:34 PDT
Created attachment 402434 [details]
Patch
Comment 8 Wenson Hsieh 2020-06-21 17:53:23 PDT
Comment on attachment 402434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402434&action=review

> LayoutTests/fast/events/platform-wheelevent-in-scrolling-div.html:28
> +                eventSender.callAfterScrollingCompletes(() => {
> +                    checkOffsets();
> +                });

Nit - I think this would read better as `eventSender.callAfterScrollingCompletes(checkOffsets);`
Comment 9 Simon Fraser (smfr) 2020-06-21 18:07:10 PDT
Created attachment 402435 [details]
For landing
Comment 10 Simon Fraser (smfr) 2020-06-21 20:37:05 PDT
EWS still shows a timeout :(
Comment 11 Simon Fraser (smfr) 2020-06-22 21:18:49 PDT
Created attachment 402533 [details]
Patch
Comment 12 Simon Fraser (smfr) 2020-06-22 21:23:12 PDT
Created attachment 402534 [details]
Patch
Comment 13 Tim Horton 2020-06-22 21:43:34 PDT
Comment on attachment 402534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402534&action=review

> Tools/ChangeLog:9
> +        The variadic CGEventCreateScrollWheelEvent() seems to have an issue that causes the resulting event

Seems mysterious and worth a radar??
Comment 14 Alexey Proskuryakov 2020-06-22 22:05:13 PDT
Very nice!
Comment 15 EWS 2020-06-23 08:14:16 PDT
Committed r263396: <https://trac.webkit.org/changeset/263396>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402534 [details].