Bug 213351 – [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Karl Rackler]

fast/events/platform-wheelevent-in-scrolling-div.html

We are seeing this test failing on Catalina WK2.  Infrequent failure.  We are seeing once every one to two days.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fplatform-wheelevent-in-scrolling-div.html


Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fast/events/platform-wheelevent-in-scrolling-div-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fast/events/platform-wheelevent-in-scrolling-div-actual.txt
@@ -1,6 +1,3 @@
-PASS event.wheelDeltaY is window.expectedScrollTop*-120
-PASS event.wheelDeltaX is window.expectedScrollLeft*-120
-PASS event.wheelDelta is window.expectedScrollTop*-120
-PASS div.scrollTop is window.expectedScrollTop*window.pixelsPerWheelTick
-PASS div.scrollLeft is window.expectedScrollLeft*window.pixelsPerWheelTick
+FAIL div.scrollTop should be 200. Was 0.
+FAIL div.scrollLeft should be 120. Was 0.

[Radar WebKit Bug Importer]

<rdar://problem/64502429>

[Karl Rackler]

Unable to reproduce this failure locally using run-webkit-test.

[Karl Rackler]

Created attachment 402248 [details]
Patch

[Truitt Savell]

Comment on attachment 402248 [details]
Patch

Clearing flags on attachment: 402248

Committed r263244: <https://trac.webkit.org/changeset/263244>

[Truitt Savell]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Reopening after landing test expectations

[Simon Fraser (smfr)]

Created attachment 402434 [details]
Patch

[Wenson Hsieh]

Comment on attachment 402434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402434&action=review

> LayoutTests/fast/events/platform-wheelevent-in-scrolling-div.html:28
> +                eventSender.callAfterScrollingCompletes(() => {
> +                    checkOffsets();
> +                });

Nit - I think this would read better as `eventSender.callAfterScrollingCompletes(checkOffsets);`

[Simon Fraser (smfr)]

Created attachment 402435 [details]
For landing

[Simon Fraser (smfr)]

EWS still shows a timeout :(

[Simon Fraser (smfr)]

Created attachment 402533 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 402534 [details]
Patch

[Tim Horton]

Comment on attachment 402534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402534&action=review

> Tools/ChangeLog:9
> +        The variadic CGEventCreateScrollWheelEvent() seems to have an issue that causes the resulting event

Seems mysterious and worth a radar??

[Alexey Proskuryakov]

Very nice!

[EWS]

Committed r263396: <https://trac.webkit.org/changeset/263396>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402534 [details].