Bug 213346 - Workaround for UIKit layout bug in time picker.
Summary: Workaround for UIKit layout bug in time picker.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-18 11:48 PDT by Megan Gardner
Modified: 2020-06-18 15:16 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2020-06-18 11:57 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (2.04 KB, patch)
2020-06-18 14:35 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-06-18 11:48:27 PDT
Workaround for UIKit layout bug in time picker.
Comment 1 Megan Gardner 2020-06-18 11:57:12 PDT
Created attachment 402222 [details]
Patch
Comment 2 Tim Horton 2020-06-18 12:06:08 PDT
Comment on attachment 402222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402222&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:82
> +    // FIXME: Workaround, should be able to be readresses after <rdar://problem/64143534>

"readdresses" -> readdressed?

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88
> +        view.layoutMargins = (UIEdgeInsets) {16, 16, 16, 16};

We usually use UIEdgeInsetsMake
Comment 3 Megan Gardner 2020-06-18 14:35:52 PDT
Created attachment 402237 [details]
Patch for landing
Comment 4 Megan Gardner 2020-06-18 14:36:23 PDT
<rdar://problem/64042277>
Comment 5 EWS 2020-06-18 15:16:30 PDT
Committed r263232: <https://trac.webkit.org/changeset/263232>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402237 [details].