Bug 213337 - [GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
Summary: [GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 213340
  Show dependency tree / graph
 
Reported: 2020-06-18 05:13 PDT by Carlos Garcia Campos
Modified: 2020-06-22 22:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.94 KB, patch)
2020-06-18 05:30 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-06-18 05:13:05 PDT 
The default path is always used.
Comment 1 Carlos Garcia Campos 2020-06-18 05:30:26 PDT 
Created attachment 402201 [details]
Patch
Comment 2 EWS Watchlist 2020-06-18 05:31:03 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2020-06-22 00:56:42 PDT 
Comment on attachment 402201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402201&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:241
> +            priv->domCacheDirectory.reset(g_build_filename(priv->baseCacheDirectory.get(), "CacheStorage", nullptr));

I wonder why this is “CamelCase” while the other directories
are “allsmallcaps” 🤔️
Comment 4 Carlos Garcia Campos 2020-06-22 01:25:12 PDT 
(In reply to Adrian Perez from comment #3)
> Comment on attachment 402201 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402201&action=review
> 
> > Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:241
> > +            priv->domCacheDirectory.reset(g_build_filename(priv->baseCacheDirectory.get(), "CacheStorage", nullptr));
> 
> I wonder why this is “CamelCase” while the other directories
> are “allsmallcaps” 🤔️

Because it's consistent with the default directory name.
Comment 5 Adrian Perez 2020-06-22 01:47:02 PDT 
(In reply to Carlos Garcia Campos from comment #4)
> (In reply to Adrian Perez from comment #3)
> > Comment on attachment 402201 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=402201&action=review
> > 
> > > Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:241
> > > +            priv->domCacheDirectory.reset(g_build_filename(priv->baseCacheDirectory.get(), "CacheStorage", nullptr));
> > 
> > I wonder why this is “CamelCase” while the other directories
> > are “allsmallcaps” 🤔️
> 
> Because it's consistent with the default directory name.

Aye, no more questions then, let's land this 👍️
Comment 6 Carlos Garcia Campos 2020-06-22 22:49:33 PDT 
Committed r263386: <https://trac.webkit.org/changeset/263386>