Bug 213320 – [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

<rdar://problem/63831962>

[Wenson Hsieh]

Created attachment 402167 [details]
Patch

[Tim Horton]

Comment on attachment 402167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848
> +    if (event.charCode() != 9)

Even '\t' might be preferable to this MAGICAL 9.

[Wenson Hsieh]

(In reply to Tim Horton from comment #2)
> Comment on attachment 402167 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402167&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2848
> > +    if (event.charCode() != 9)
> 
> Even '\t' might be preferable to this MAGICAL 9.

Good call!

[Darin Adler]

Comment on attachment 402167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852
> +    if (!event.shiftKey())
> +        return false;

What about other modifiers like control, option, and command?

[Wenson Hsieh]

Comment on attachment 402167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402167&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2852
>> +        return false;
> 
> What about other modifiers like control, option, and command?

Oops, that's right — we probably ought to avoid relinquishing focus if any of the other modifier keys are set.

[Darin Adler]

But maybe not caps lock. This keyboard mapping to commands business is rough.

[Wenson Hsieh]

Created attachment 402170 [details]
For EWS

[Wenson Hsieh]

Committed r263196: <https://trac.webkit.org/changeset/263196>