Bug 213311 - REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
Summary: REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContent...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 11:33 PDT by Ryan Haddad
Modified: 2020-06-17 15:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2020-06-17 12:38 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-06-17 11:33:52 PDT 
TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure on macOS bots

    TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:2481
        Value of: foundNewItemAfterCompletingTextManipulation
          Actual: false
        Expected: true

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem
Comment 1 Ryan Haddad 2020-06-17 11:34:41 PDT 
It looks like this started with https://trac.webkit.org/changeset/263044/webkit
Comment 2 Radar WebKit Bug Importer 2020-06-17 11:34:58 PDT 
<rdar://problem/64456413>
Comment 3 Ryan Haddad 2020-06-17 11:36:00 PDT 
The test was renamed as part of that commit, it doesn't look like it used to be flaky when it was called TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem
Comment 4 Sihui Liu 2020-06-17 12:38:07 PDT 
Created attachment 402145 [details]
Patch
Comment 5 EWS 2020-06-17 15:46:55 PDT 
Committed r263186: <https://trac.webkit.org/changeset/263186>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402145 [details].