Bug 213305 - Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally
Summary: Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 10:33 PDT by Alex Christensen
Modified: 2020-06-17 11:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2020-06-17 10:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-06-17 10:33:47 PDT 
Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally
Comment 1 Alex Christensen 2020-06-17 10:34:44 PDT 
Created attachment 402130 [details]
Patch
Comment 2 Alexey Proskuryakov 2020-06-17 10:43:43 PDT 
Comment on attachment 402130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review

> Source/WebKit/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).

No test?
Comment 3 Alex Christensen 2020-06-17 10:47:05 PDT 
Comment on attachment 402130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review

>> Source/WebKit/ChangeLog:7
>> +        Reviewed by NOBODY (OOPS!).
> 
> No test?

No test.  I believe our crash logs justify this change, and Brady's comment in radar convinces me that this is an edge case happening during teardown.
Comment 4 Brady Eidson 2020-06-17 11:02:18 PDT 
Comment on attachment 402130 [details]
Patch

No test in deed - one of those cases where it's obvious what's happening but not feasible to get it happening reliably for testing.
Comment 5 EWS 2020-06-17 11:16:25 PDT 
Committed r263169: <https://trac.webkit.org/changeset/263169>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402130 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-17 11:17:19 PDT 
<rdar://problem/64455684>