Bug 213304 - $vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
Summary: $vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 10:22 PDT by Keith Miller
Modified: 2020-06-17 11:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2020-06-17 10:22 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (4.76 KB, patch)
2020-06-17 10:27 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2020-06-17 10:32 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (5.25 KB, patch)
2020-06-17 10:39 PDT, Keith Miller 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.36 KB, patch)
2020-06-17 10:42 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (5.51 KB, patch)
2020-06-17 10:55 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-06-17 10:22:35 PDT 
$vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
Comment 1 Keith Miller 2020-06-17 10:22:57 PDT 
Created attachment 402125 [details]
Patch
Comment 2 Keith Miller 2020-06-17 10:27:08 PDT 
Created attachment 402127 [details]
Patch
Comment 3 Mark Lam 2020-06-17 10:29:27 PDT 
Comment on attachment 402127 [details]
Patch

r=me
Comment 4 Keith Miller 2020-06-17 10:32:58 PDT 
Created attachment 402128 [details]
Patch
Comment 5 Keith Miller 2020-06-17 10:39:54 PDT 
Created attachment 402131 [details]
Patch for landing
Comment 6 Keith Miller 2020-06-17 10:42:40 PDT 
Created attachment 402132 [details]
Patch for landing
Comment 7 Keith Miller 2020-06-17 10:55:34 PDT 
Created attachment 402133 [details]
Patch for landing
Comment 8 Saam Barati 2020-06-17 11:05:44 PDT 
Comment on attachment 402133 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=402133&action=review

> Source/JavaScriptCore/ChangeLog:13
> +        the first parameter even if it's not a JSGlobalObject. If no

I feel like we should rename this then to express what new semantics are?
Comment 9 Keith Miller 2020-06-17 11:08:03 PDT 
Comment on attachment 402133 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=402133&action=review

>> Source/JavaScriptCore/ChangeLog:13
>> +        the first parameter even if it's not a JSGlobalObject. If no
> 
> I feel like we should rename this then to express what new semantics are?

I kinda think, with this change, the no parameter case is the primary case. In that world the current name makes sense, IMO. The first parameter is just for convenience.
Comment 10 EWS 2020-06-17 11:10:23 PDT 
Patch 402131 does not build
Comment 11 EWS 2020-06-17 11:40:20 PDT 
Committed r263174: <https://trac.webkit.org/changeset/263174>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402133 [details].
Comment 12 Radar WebKit Bug Importer 2020-06-17 11:41:24 PDT 
<rdar://problem/64456665>