Bug 213294 - media/remoteplayback-target-availability.html was a flaky failure after r262904
Summary: media/remoteplayback-target-availability.html was a flaky failure after r262904
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 07:48 PDT by Geoffrey Garen
Modified: 2022-02-28 03:35 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.44 KB, patch)
2020-06-17 08:08 PDT, Geoffrey Garen
sam: review+
Details | Formatted Diff | Diff
Patch for landing (7.42 KB, patch)
2020-06-17 11:30 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2020-06-17 07:48:24 PDT
media/remoteplayback-target-availability.html was a flaky failure after r262904
Comment 1 Geoffrey Garen 2020-06-17 08:08:58 PDT
Created attachment 402108 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-17 08:09:25 PDT
Let's see what EWS thinks....
Comment 3 Sam Weinig 2020-06-17 08:59:40 PDT
Comment on attachment 402108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402108&action=review

Fantastic ChangeLog!

> Source/WebCore/ChangeLog:28
> +        state when we enqueue our task, and do not update it when we deqeueu our

Typo: "deqeueu" should be "dequeue"
Comment 4 Geoffrey Garen 2020-06-17 11:26:25 PDT
Comment on attachment 402108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402108&action=review

>> Source/WebCore/ChangeLog:28
>> +        state when we enqueue our task, and do not update it when we deqeueu our
> 
> Typo: "deqeueu" should be "dequeue"

I cannot tell you how many times I hadd tto reetype that.
Comment 5 Geoffrey Garen 2020-06-17 11:30:58 PDT
Created attachment 402135 [details]
Patch for landing
Comment 6 EWS 2020-06-17 11:55:36 PDT
Committed r263175: <https://trac.webkit.org/changeset/263175>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402135 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-17 11:56:21 PDT
<rdar://problem/64457268>