Bug 213286 - Enable stale-while-revalidate support by default
Summary: Enable stale-while-revalidate support by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 01:14 PDT by Rob Buis
Modified: 2020-06-19 09:19 PDT (History)
10 users (show)

See Also:

Attachments
Patch (55.95 KB, patch)
2020-06-17 01:52 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2020-06-17 04:21 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-06-17 01:14:27 PDT 
Enable stale-while-revalidate support by default by removing the build flag.
Comment 1 Rob Buis 2020-06-17 01:52:33 PDT 
Created attachment 402093 [details]
Patch
Comment 2 youenn fablet 2020-06-17 02:48:18 PDT 
This seems ok to remove the build flag.
Should we also contemplate changing WebsiteDataStoreConfiguration::m_networkCacheSpeculativeValidationEnabled value, or in a separate patch maybe?
Comment 3 Rob Buis 2020-06-17 04:21:39 PDT 
Created attachment 402098 [details]
Patch
Comment 4 Rob Buis 2020-06-17 06:10:32 PDT 
I think this may be the best way to do it. Just removing the build flag will fail for platforms not building with speculative load. And just replacing the s-w-r build flag with speculative load build flag would probably be confusing.
Comment 5 EWS 2020-06-19 09:18:48 PDT 
Committed r263269: <https://trac.webkit.org/changeset/263269>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402098 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-19 09:19:17 PDT 
<rdar://problem/64533689>