Bug 213285 - Enable referrer policy attribute support by default
Summary: Enable referrer policy attribute support by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 00:35 PDT by Rob Buis
Modified: 2020-06-19 10:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2020-06-17 00:45 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2020-06-17 03:26 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-06-17 00:35:44 PDT
Enable referrer policy attribute support by default by flipping the switch.
Comment 1 Rob Buis 2020-06-17 00:45:15 PDT
Created attachment 402088 [details]
Patch
Comment 2 youenn fablet 2020-06-17 02:44:09 PDT
Comment on attachment 402088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402088&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:621
> +    bool m_referrerPolicyAttributeEnabled { true };

Probably need to change WebPreferences.yaml as well
Comment 3 Rob Buis 2020-06-17 03:26:17 PDT
Created attachment 402096 [details]
Patch
Comment 4 Rob Buis 2020-06-17 03:27:13 PDT
Comment on attachment 402088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402088&action=review

>> Source/WebCore/page/RuntimeEnabledFeatures.h:621
>> +    bool m_referrerPolicyAttributeEnabled { true };
> 
> Probably need to change WebPreferences.yaml as well

I forgot about that one, it was a long time ago :) Fixed.
Comment 5 EWS 2020-06-17 05:51:27 PDT
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 6 EWS 2020-06-19 10:07:41 PDT
Committed r263274: <https://trac.webkit.org/changeset/263274>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402096 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-19 10:08:17 PDT
<rdar://problem/64535223>