Bug 213274 - update-webkit-localizable-strings exits without writing localized strings because of an R"" string
Summary: update-webkit-localizable-strings exits without writing localized strings bec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
: 213273 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-16 17:04 PDT by Said Abou-Hallawa
Modified: 2020-07-06 13:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2020-07-06 11:49 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-06-16 17:04:01 PDT 
When adding new localized strings in WebKit and running update-webkit-localizable-strings, I get the following errors:

    Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:929: mismatched quotes
    Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:946: mismatched quotes

    577 localizable strings
    41665 strings not marked for localization

    Errors encountered. Exiting without writing to Source/WebCore/en.lproj/Localizable.strings.

When commenting the R"" string in joinSubStatisticsForSorting() and rerunning the tool, the localized strings are generated as expected.
Comment 1 Radar WebKit Bug Importer 2020-06-16 17:04:37 PDT 
<rdar://problem/64427891>
Comment 2 Andy Estes 2020-06-16 17:06:47 PDT 
*** Bug 213273 has been marked as a duplicate of this bug. ***
Comment 3 Kate Cheney 2020-07-06 11:49:33 PDT 
Created attachment 403602 [details]
Patch
Comment 4 EWS 2020-07-06 13:19:55 PDT 
Committed r263982: <https://trac.webkit.org/changeset/263982>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403602 [details].