Bug 213270 – REGRESSION: ASSERTION FAILED: g_jscConfig.options.allowUnfinalizedAccess || g_jscConfig.options.isFinalized seen with TestWebKitAPI.WebCore.WildcardStringMatching

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

The following API test is asserting on macOS debug bots:

    TestWebKitAPI.WebCore.WildcardStringMatching
        ASSERTION FAILED: g_jscConfig.options.allowUnfinalizedAccess || g_jscConfig.options.isFinalized
        /Volumes/Data/slave/catalina-debug/build/Source/JavaScriptCore/runtime/Options.h(132) : static OptionsStorage::Bool &JSC::Options::dumpCompiledRegExpPatterns()
        1   0x108083539 WTFCrash
        2   0x10884b19b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x109aa68a9 JSC::Options::dumpCompiledRegExpPatterns()
        4   0x109e51d88 JSC::Yarr::YarrPattern::compile(WTF::String const&)
        5   0x109e52765 JSC::Yarr::YarrPattern::YarrPattern(WTF::String const&, WTF::OptionSet<JSC::Yarr::Flags>, JSC::Yarr::ErrorCode&)
        6   0x109e527ec JSC::Yarr::YarrPattern::YarrPattern(WTF::String const&, WTF::OptionSet<JSC::Yarr::Flags>, JSC::Yarr::ErrorCode&)
        7   0x109e09933 JSC::Yarr::RegularExpression::Private::compile(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode)
        8   0x109e0981f JSC::Yarr::RegularExpression::Private::Private(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode)
        9   0x109e09751 JSC::Yarr::RegularExpression::Private::Private(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode)
        10  0x109e055b8 JSC::Yarr::RegularExpression::Private::create(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode)
        11  0x109e0554c JSC::Yarr::RegularExpression::RegularExpression(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode)
        12  0x109e05651 JSC::Yarr::RegularExpression::RegularExpression(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode)
        13  0x11e74ad3f WebCore::stringMatchesWildcardString(WTF::String const&, WTF::String const&)
        14  0x1054c2ce6 TestWebKitAPI::WebCore_WildcardStringMatching_Test::TestBody()
        15  0x10581ae14 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        16  0x1057e95db void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        17  0x1057e9516 testing::Test::Run()
        18  0x1057ea6aa testing::TestInfo::Run()
        19  0x1057eb594 testing::TestCase::Run()
        20  0x1057f6c48 testing::internal::UnitTestImpl::RunAllTests()
        21  0x10581fe14 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        22  0x1057f673b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        23  0x1057f660d testing::UnitTest::Run()
        24  0x1055cda51 RUN_ALL_TESTS()
        25  0x1055cd9e2 TestWebKitAPI::TestsController::run(int, char**)
        26  0x1057b5d5c main
        27  0x7fff709fdcc9 start

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebCore.WildcardStringMatching

[Ryan Haddad]

This is related to https://trac.webkit.org/changeset/263117/webkit

[Radar WebKit Bug Importer]

<rdar://problem/64427499>

[Mark Lam]

Created attachment 402066 [details]
proposed patch.

[Yusuke Suzuki]

Comment on attachment 402066 [details]
proposed patch.

r=me

[Mark Lam]

Thanks for the review.  Landed in r263133: <http://trac.webkit.org/r263133>.