WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
213264
Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues
https://bugs.webkit.org/show_bug.cgi?id=213264
Summary
Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues
David Kilzer (:ddkilzer)
Reported
2020-06-16 15:11:18 PDT
Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues. Upon further reflection, we should just use EnumTraits/EnumValues for validating OptionSet<>. There's no need to duplicate these enum value lists, and it removes duplicate lists for WebCore::DragOperation and WebCore::DragSourceAction in DragActions.h.
Attachments
Patch v1
(7.71 KB, patch)
2020-06-16 15:15 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-06-16 15:11:35 PDT
<
rdar://problem/64423749
>
David Kilzer (:ddkilzer)
Comment 2
2020-06-16 15:15:19 PDT
Created
attachment 402046
[details]
Patch v1
Brent Fulgham
Comment 3
2020-06-17 12:31:22 PDT
Comment on
attachment 402046
[details]
Patch v1 Code removal! Yes. r=me
EWS
Comment 4
2020-06-17 12:52:18 PDT
Committed
r263178
: <
https://trac.webkit.org/changeset/263178
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 402046
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug