Bug 213264 - Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues
Summary: Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 212397
Blocks: 213199
  Show dependency tree / graph
 
Reported: 2020-06-16 15:11 PDT by David Kilzer (:ddkilzer)
Modified: 2020-06-17 12:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch v1 (7.71 KB, patch)
2020-06-16 15:15 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-06-16 15:11:18 PDT 
Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues.

Upon further reflection, we should just use EnumTraits/EnumValues for validating OptionSet<>.

There's no need to duplicate these enum value lists, and it removes duplicate lists for WebCore::DragOperation and WebCore::DragSourceAction in DragActions.h.
Comment 1 Radar WebKit Bug Importer 2020-06-16 15:11:35 PDT 
<rdar://problem/64423749>
Comment 2 David Kilzer (:ddkilzer) 2020-06-16 15:15:19 PDT 
Created attachment 402046 [details]
Patch v1
Comment 3 Brent Fulgham 2020-06-17 12:31:22 PDT 
Comment on attachment 402046 [details]
Patch v1

Code removal! Yes. r=me
Comment 4 EWS 2020-06-17 12:52:18 PDT 
Committed r263178: <https://trac.webkit.org/changeset/263178>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402046 [details].