Bug 213261 – Check for inAppBrowserPrivacyEnabled flag in WebsiteDataStore::initializeAppBoundDomains is expensive and calls a non-static function WebsiteDataStore::parameters().

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

appBoundDomains() is static, so initializing it should not rely on non-static functions, like WebsiteDataStore::parameters(). Also the call to WebsiteDataStore::parameters() is expensive and unnecessary when we really only need to check the value of one flag.

[Kate Cheney]

<rdar://problem/64317084>

[Kate Cheney]

Created attachment 402043 [details]
Patch

[Brent Fulgham]

Comment on attachment 402043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402043&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:455
> +        RunLoop::main().dispatch([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable {

I think we could just WTFMove(protectedThis).

[Kate Cheney]

Created attachment 402047 [details]
Patch for landing

[Kate Cheney]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 402043 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402043&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:455
> > +        RunLoop::main().dispatch([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)] () mutable {
> 
> I think we could just WTFMove(protectedThis).

Good call, thanks for the review!

[EWS]

Committed r263122: <https://trac.webkit.org/changeset/263122>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402047 [details].