Bug 213251 - Text manipulation should handle nested item boundary elements
Summary: Text manipulation should handle nested item boundary elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-16 09:10 PDT by Wenson Hsieh
Modified: 2020-06-16 11:11 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.55 KB, patch)
2020-06-16 09:23 PDT, Wenson Hsieh 		sihui_liu: review+
Details | Formatted Diff | Diff
Patch for landing (6.32 KB, patch)
2020-06-16 10:40 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-06-16 09:10:49 PDT 
<rdar://problem/63371514>
Comment 1 Wenson Hsieh 2020-06-16 09:23:04 PDT 
Created attachment 402011 [details]
Patch
Comment 2 Sihui Liu 2020-06-16 10:18:00 PDT 
Comment on attachment 402011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402011&action=review

> Source/WebCore/editing/TextManipulationController.cpp:419
> +        bool crossedItemBoundary = false;

This boolean is probably not needed. addItemIfPossible does not add item when units is empty.
Comment 3 Wenson Hsieh 2020-06-16 10:35:51 PDT 
(In reply to Sihui Liu from comment #2)
> Comment on attachment 402011 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402011&action=review
> 
> > Source/WebCore/editing/TextManipulationController.cpp:419
> > +        bool crossedItemBoundary = false;
> 
> This boolean is probably not needed. addItemIfPossible does not add item
> when units is empty.

Good point! Removed crossedItemBoundary.
Comment 4 Wenson Hsieh 2020-06-16 10:40:02 PDT 
Created attachment 402022 [details]
Patch for landing
Comment 5 EWS 2020-06-16 11:11:28 PDT 
Committed r263101: <https://trac.webkit.org/changeset/263101>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402022 [details].