RESOLVED FIXED213251
Text manipulation should handle nested item boundary elements 
https://bugs.webkit.org/show_bug.cgi?id=213251
Summary Text manipulation should handle nested item boundary elements
Wenson Hsieh
Reported 2020-06-16 09:10:49 PDT
<rdar://problem/63371514>
Attachments
Patch (6.55 KB, patch)
2020-06-16 09:23 PDT, Wenson Hsieh 		sihui_liu: review+
DetailsFormatted DiffDiff
Patch for landing (6.32 KB, patch)
2020-06-16 10:40 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-06-16 09:23:04 PDT
Created attachment 402011 [details] Patch
Sihui Liu
Comment 2 2020-06-16 10:18:00 PDT
Comment on attachment 402011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402011&action=review > Source/WebCore/editing/TextManipulationController.cpp:419 > + bool crossedItemBoundary = false; This boolean is probably not needed. addItemIfPossible does not add item when units is empty.
Wenson Hsieh
Comment 3 2020-06-16 10:35:51 PDT
(In reply to Sihui Liu from comment #2) > Comment on attachment 402011 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402011&action=review > > > Source/WebCore/editing/TextManipulationController.cpp:419 > > + bool crossedItemBoundary = false; > > This boolean is probably not needed. addItemIfPossible does not add item > when units is empty. Good point! Removed crossedItemBoundary.
Wenson Hsieh
Comment 4 2020-06-16 10:40:02 PDT
Created attachment 402022 [details] Patch for landing
EWS
Comment 5 2020-06-16 11:11:28 PDT
Committed r263101: <https://trac.webkit.org/changeset/263101> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402022 [details].
Note You need to log in before you can comment on or make changes to this bug.