WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
213234
Web Inspector: Sources: objects in Scope Chain panel flicker when resizing details sidebar
https://bugs.webkit.org/show_bug.cgi?id=213234
Summary
Web Inspector: Sources: objects in Scope Chain panel flicker when resizing de...
Devin Rousso
Reported
2020-06-15 22:00:17 PDT
# STEPS TO REPRODUCE 1. inspect any page 2. set a JavaScript breakpoint 3. trigger the breakpoint from step #2 4. select the Scope Chain panel in the details sidebar 5. resize the details sidebar => objects in the Scope Chain panel flicker
Attachments
Patch
(1.78 KB, patch)
2020-06-15 22:02 PDT
,
Devin Rousso
ddkilzer
: review+
Details
Formatted Diff
Diff
Patch
(1.77 KB, patch)
2020-06-16 13:46 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2020-06-15 22:00:34 PDT
<
rdar://problem/64391213
>
Devin Rousso
Comment 2
2020-06-15 22:02:31 PDT
Created
attachment 401981
[details]
Patch
David Kilzer (:ddkilzer)
Comment 3
2020-06-16 12:08:34 PDT
Comment on
attachment 401981
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=401981&action=review
> Source/WebInspectorUI/ChangeLog:12 > + Don't regenerate the DOM if the `layout` unless the reason is `WI.View.LayoutReason.Dirty`, > + such as if the current call frame changes or a watch expression is added/updated/removed.
"Don't regenerate the DOM if the `layout`..." does what? (Sentence doesn't read properly.)
Devin Rousso
Comment 4
2020-06-16 13:38:35 PDT
Comment on
attachment 401981
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=401981&action=review
>> Source/WebInspectorUI/ChangeLog:12 >> + such as if the current call frame changes or a watch expression is added/updated/removed. > > "Don't regenerate the DOM if the `layout`..." does what? (Sentence doesn't read properly.)
Oh oops I meant "Don't regenerate the DOM in `layout` unless ..." 😅
Devin Rousso
Comment 5
2020-06-16 13:46:36 PDT
Created
attachment 402035
[details]
Patch
EWS
Comment 6
2020-06-16 14:11:29 PDT
Committed
r263115
: <
https://trac.webkit.org/changeset/263115
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 402035
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug