Bug 213221 - REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document::prepareCanvasesForDisplayIfNeeded
Summary: REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-15 16:10 PDT by Dean Jackson
Modified: 2020-06-16 17:49 PDT (History)
11 users (show)

See Also:

Attachments
Patch (15.52 KB, patch)
2020-06-15 16:22 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (7.50 KB, patch)
2020-06-16 15:34 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-06-15 16:10:24 PDT 
REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document::prepareCanvasesForDisplayIfNeeded
Comment 1 Dean Jackson 2020-06-15 16:11:19 PDT 
rdar://64260400
Comment 2 Dean Jackson 2020-06-15 16:22:07 PDT 
Created attachment 401954 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-06-15 16:29:26 PDT 
Comment on attachment 401954 [details]
Patch

I think you should split this into two patches.
Comment 4 Dean Jackson 2020-06-16 15:34:02 PDT 
Created attachment 402049 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-06-16 15:48:31 PDT 
Comment on attachment 402049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402049&action=review

> Source/WebCore/dom/Document.h:1601
> +    void clearCanvasPreparation(HTMLCanvasElement*);

I don't like how we have multiple ways we do this. There's generic Element::didMove... stuff, there's HTMLMediaElement::unregisterWithDocument(), Document::unregisterForCaptionPreferencesChangedCallbacks(), Document::unregisterArticleElement() etc.

We should add one overridable hook for elements that need to do custom document removal. Maybe not in this patch.
Comment 6 Dean Jackson 2020-06-16 17:49:07 PDT 
Committed r263128: <https://trac.webkit.org/changeset/263128>