Bug 213219 - Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
Summary: Multiple hypothesis testing should use False Discovery Rate instead of Bonfer...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-15 15:07 PDT by Saam Barati
Modified: 2020-06-16 16:29 PDT (History)
4 users (show)

See Also:

Attachments
patch (6.90 KB, patch)
2020-06-15 17:53 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-06-15 15:07:16 PDT 
...
Comment 1 Saam Barati 2020-06-15 17:53:50 PDT 
Created attachment 401961 [details]
patch
Comment 2 Mark Lam 2020-06-16 13:49:16 PDT 
Comment on attachment 401961 [details]
patch

r=me
Comment 3 EWS 2020-06-16 14:09:33 PDT 
Committed r263114: <https://trac.webkit.org/changeset/263114>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401961 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-16 14:10:25 PDT 
<rdar://problem/64421181>
Comment 5 Darin Adler 2020-06-16 15:58:07 PDT 
Comment on attachment 401961 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401961&action=review

> Tools/Scripts/compare-results:181
> +    isSignifcant = computeMultipleHypothesesSignficance(a, b)

typo: "signifcant"
Comment 6 Saam Barati 2020-06-16 16:22:38 PDT 
(In reply to Darin Adler from comment #5)
> Comment on attachment 401961 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401961&action=review
> 
> > Tools/Scripts/compare-results:181
> > +    isSignifcant = computeMultipleHypothesesSignficance(a, b)
> 
> typo: "signifcant"

Ah, I typod it twice! "Signficance" too

Will fix
Comment 7 Saam Barati 2020-06-16 16:29:41 PDT 
fixed in:
https://trac.webkit.org/changeset/263124/webkit