Bug 21320 - leaks of PropertyNameArrayData seen on buildbot
: leaks of PropertyNameArrayData seen on buildbot
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P1 Normal
Assigned To: Sam Weinig
Depends on:
Blocks: 21513
  Show dependency treegraph
Reported: 2008-10-02 16:09 PDT by Geoffrey Garen
Modified: 2008-10-13 16:03 PDT (History)
0 users

See Also:

patch (3.29 KB, patch)
2008-10-04 14:32 PDT, Sam Weinig
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-10-02 16:09:10 PDT
StructureID holds a RefPtr to PropertyNameArrayData, and vice-versa. That's the leak.

Sam mentioned that PropertyNameArrayData's pointer could be a weak pointer instead, cleared in the StructureID destructor.
Comment 1 Sam Weinig 2008-10-04 14:32:18 PDT
Created attachment 24092 [details]
Comment 2 Oliver Hunt 2008-10-04 14:44:31 PDT
Comment on attachment 24092 [details]

r=me -- test case?
Comment 3 Sam Weinig 2008-10-04 14:59:16 PDT
Fixed in r37300.