Bug 21320 - leaks of PropertyNameArrayData seen on buildbot
Summary: leaks of PropertyNameArrayData seen on buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks: 21513
  Show dependency tree / graph
 
Reported: 2008-10-02 16:09 PDT by Geoffrey Garen
Modified: 2008-10-13 16:03 PDT (History)
0 users

See Also:

Attachments
patch (3.29 KB, patch)
2008-10-04 14:32 PDT, Sam Weinig 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-10-02 16:09:10 PDT 
StructureID holds a RefPtr to PropertyNameArrayData, and vice-versa. That's the leak.

Sam mentioned that PropertyNameArrayData's pointer could be a weak pointer instead, cleared in the StructureID destructor.
Comment 1 Sam Weinig 2008-10-04 14:32:18 PDT 
Created attachment 24092 [details]
patch
Comment 2 Oliver Hunt 2008-10-04 14:44:31 PDT 
Comment on attachment 24092 [details]
patch

r=me -- test case?
Comment 3 Sam Weinig 2008-10-04 14:59:16 PDT 
Fixed in r37300.