Bug 213184 - [LFC][Floats] Remove FloatBox class
Summary: [LFC][Floats] Remove FloatBox class
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2020-06-14 10:27 PDT by zalan
Modified: 2020-06-17 07:06 PDT (History)
5 users (show)

See Also:

Patch (35.01 KB, patch)
2020-06-14 10:36 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-06-14 10:27:37 PDT
apparently the only difference between a non-floating float avoider (regular formatting context root) and a float box is that while float boxes intersect their margin box, simple float avoiders use their border box. We can do that without subclassing FloatAvoider.
Comment 1 zalan 2020-06-14 10:36:31 PDT
Created attachment 401863 [details]
Comment 2 Antti Koivisto 2020-06-17 06:56:05 PDT
Comment on attachment 401863 [details]

Comment 3 EWS 2020-06-17 07:05:50 PDT
Committed r263144: <https://trac.webkit.org/changeset/263144>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401863 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-17 07:06:24 PDT