Bug 213183 - [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
Summary: [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-14 10:15 PDT by Wenson Hsieh
Modified: 2020-06-18 16:04 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.19 KB, patch)
2020-06-14 10:42 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Typo fix (7.12 KB, patch)
2020-06-14 10:47 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (7.11 KB, patch)
2020-06-14 10:50 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Highly speculative fix... (8.13 KB, patch)
2020-06-14 15:19 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (1.49 KB, patch)
2020-06-18 15:44 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-06-14 10:15:55 PDT 
They are:

• KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder
• KeyboardInputTests.RangedSelectionRectAfterRestoringFirstResponder
Comment 1 Wenson Hsieh 2020-06-14 10:16:57 PDT 
<rdar://problem/64273483>
Comment 2 Wenson Hsieh 2020-06-14 10:42:31 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-06-14 10:47:59 PDT Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2020-06-14 10:50:57 PDT 
Created attachment 401866 [details]
Patch
Comment 5 Wenson Hsieh 2020-06-14 11:52:17 PDT 
For some reason, this causes KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash on iOS 13.4 :(

Need to either figure out why (or maybe just define out the test on 13.4, since trunk won't support it anyways).
Comment 6 Wenson Hsieh 2020-06-14 13:12:37 PDT 
(In reply to Wenson Hsieh from comment #5)
> For some reason, this causes
> KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash
> on iOS 13.4 :(
> 
> Need to either figure out why (or maybe just define out the test on 13.4,
> since trunk won't support it anyways).

Unable to reproduce locally using the internal iOS 13.4 SDK (17E262).
Comment 7 Wenson Hsieh 2020-06-14 14:22:39 PDT 
(In reply to Wenson Hsieh from comment #6)
> (In reply to Wenson Hsieh from comment #5)
> > For some reason, this causes
> > KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash
> > on iOS 13.4 :(
> > 
> > Need to either figure out why (or maybe just define out the test on 13.4,
> > since trunk won't support it anyways).
> 
> Unable to reproduce locally using the internal iOS 13.4 SDK (17E262).

Also unable to reproduce locally using the public iOS 13.5 SDK.

Guess I'm going to have to use EWS to debug this...
Comment 8 Wenson Hsieh 2020-06-14 15:19:14 PDT 
Created attachment 401873 [details]
Highly speculative fix...
Comment 9 Wenson Hsieh 2020-06-14 16:02:42 PDT 
Comment on attachment 401873 [details]
Highly speculative fix...

Looks like that was it.
Comment 10 EWS 2020-06-14 16:06:15 PDT 
Committed r263014: <https://trac.webkit.org/changeset/263014>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401873 [details].
Comment 11 Jonathan Bedard 2020-06-18 15:44:42 PDT 
Reopening to attach new patch.
Comment 12 Jonathan Bedard 2020-06-18 15:44:43 PDT 
Created attachment 402245 [details]
Patch for landing
Comment 13 EWS 2020-06-18 16:04:49 PDT 
Committed r263241: <https://trac.webkit.org/changeset/263241>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402245 [details].