RESOLVED FIXED 213183
[iOS] Two KeyboardInputTests are failing on recent iOS SDK versions 
https://bugs.webkit.org/show_bug.cgi?id=213183
Summary [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
Wenson Hsieh
Reported 2020-06-14 10:15:55 PDT
They are: • KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder • KeyboardInputTests.RangedSelectionRectAfterRestoringFirstResponder
Attachments
Patch (7.19 KB, patch)
2020-06-14 10:42 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Typo fix (7.12 KB, patch)
2020-06-14 10:47 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (7.11 KB, patch)
2020-06-14 10:50 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Highly speculative fix... (8.13 KB, patch)
2020-06-14 15:19 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.49 KB, patch)
2020-06-18 15:44 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-06-14 10:16:57 PDT
<rdar://problem/64273483>
Wenson Hsieh
Comment 2 2020-06-14 10:42:31 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2020-06-14 10:47:59 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 4 2020-06-14 10:50:57 PDT
Created attachment 401866 [details] Patch
Wenson Hsieh
Comment 5 2020-06-14 11:52:17 PDT
For some reason, this causes KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash on iOS 13.4 :( Need to either figure out why (or maybe just define out the test on 13.4, since trunk won't support it anyways).
Wenson Hsieh
Comment 6 2020-06-14 13:12:37 PDT
(In reply to Wenson Hsieh from comment #5) > For some reason, this causes > KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash > on iOS 13.4 :( > > Need to either figure out why (or maybe just define out the test on 13.4, > since trunk won't support it anyways). Unable to reproduce locally using the internal iOS 13.4 SDK (17E262).
Wenson Hsieh
Comment 7 2020-06-14 14:22:39 PDT
(In reply to Wenson Hsieh from comment #6) > (In reply to Wenson Hsieh from comment #5) > > For some reason, this causes > > KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder to crash > > on iOS 13.4 :( > > > > Need to either figure out why (or maybe just define out the test on 13.4, > > since trunk won't support it anyways). > > Unable to reproduce locally using the internal iOS 13.4 SDK (17E262). Also unable to reproduce locally using the public iOS 13.5 SDK. Guess I'm going to have to use EWS to debug this...
Wenson Hsieh
Comment 8 2020-06-14 15:19:14 PDT
Created attachment 401873 [details] Highly speculative fix...
Wenson Hsieh
Comment 9 2020-06-14 16:02:42 PDT
Comment on attachment 401873 [details] Highly speculative fix... Looks like that was it.
EWS
Comment 10 2020-06-14 16:06:15 PDT
Committed r263014: <https://trac.webkit.org/changeset/263014> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401873 [details].
Jonathan Bedard
Comment 11 2020-06-18 15:44:42 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 12 2020-06-18 15:44:43 PDT
Created attachment 402245 [details] Patch for landing
EWS
Comment 13 2020-06-18 16:04:49 PDT
Committed r263241: <https://trac.webkit.org/changeset/263241> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402245 [details].
Note You need to log in before you can comment on or make changes to this bug.