Many tests started failing in GTK Release (Tests) build #14065 (https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/14065) https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r262995%20(14065)/results.html There are only two revisions in the build. I bisected the revisions and verified the failures started happening in r262994.
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/r263006%20(6439)/fast/loader/javascript-url-in-embed-crash-log.txt STDERR: STDERR: warning: core file may not match specified executable file. STDERR: ASSERTION FAILED: WTF::isValidEnum<E>(WTF::enumToUnderlyingType<E>(enumValue)) STDERR: ../../Source/WebKit/Platform/IPC/Encoder.h(108) : void IPC::Encoder::encode(E) [with E = WebCore::PluginLoadClientPolicy; std::enable_if_t<std::is_enum<_Tp>::value>* <anonymous> = 0] STDERR: 1 0x7f70a743bb63 WTFCrash
Sorry, just noticed this. Will look into it tomorrow. (Also forgot that GTK tests aren't run by EWS.)
I wonder if we just need to provide a default initializer for WebCore::PluginInfo::clientLoadPolicy (and ::isApplicationPlugin while we're here): diff --git a/Source/WebCore/plugins/PluginData.h b/Source/WebCore/plugins/PluginData.h index 259e3dc847e..1ca828883cc 100644 --- a/Source/WebCore/plugins/PluginData.h +++ b/Source/WebCore/plugins/PluginData.h @@ -67,7 +67,7 @@ struct PluginInfo { Vector<MimeClassInfo> mimes; - bool isApplicationPlugin; + bool isApplicationPlugin { false }; - PluginLoadClientPolicy clientLoadPolicy; + PluginLoadClientPolicy clientLoadPolicy { PluginLoadClientPolicy::Undefined }; String bundleIdentifier; #if PLATFORM(MAC)
Created attachment 402085 [details] Patch
Created attachment 402086 [details] Patch
Committed r263139: <https://trac.webkit.org/changeset/263139>
<rdar://problem/64439668>
Thank you David. Your patch fixed the regression (I run the tests locally to verify it).
(In reply to Diego Pino from comment #8) > Thank you David. Your patch fixed the regression (I run the tests locally to > verify it). Great! Thanks for testing the fix and committing it.