WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
213166
Rename executeIfJavaScriptURL to executeJavaScriptURL
https://bugs.webkit.org/show_bug.cgi?id=213166
Summary
Rename executeIfJavaScriptURL to executeJavaScriptURL
Rob Buis
Reported
2020-06-13 09:37:46 PDT
Rename executeIfJavaScriptURL to executeJavaScriptURL in order to make the function unconditional, i.e. the passed url is expected to have the javascript protocol, this is asserted first thing in the method. This allows us to remove the return parameter since the remaining return statements all return true.
Attachments
Patch
(7.27 KB, patch)
2020-06-13 09:39 PDT
,
Rob Buis
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
2020-06-13 09:39:26 PDT
Created
attachment 401839
[details]
Patch
EWS
Comment 2
2020-06-13 23:34:46 PDT
Committed
r263008
: <
https://trac.webkit.org/changeset/263008
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 401839
[details]
.
Radar WebKit Bug Importer
Comment 3
2020-06-13 23:35:15 PDT
<
rdar://problem/64337106
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug