Bug 213166 - Rename executeIfJavaScriptURL to executeJavaScriptURL
Summary: Rename executeIfJavaScriptURL to executeJavaScriptURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-13 09:37 PDT by Rob Buis
Modified: 2020-06-13 23:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.27 KB, patch)
2020-06-13 09:39 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-06-13 09:37:46 PDT 
Rename executeIfJavaScriptURL to executeJavaScriptURL in order to make the function unconditional, i.e.
the passed url is expected to have the javascript protocol, this is asserted first thing in the method. 
This allows us to remove the return parameter since the remaining return statements all return true.
Comment 1 Rob Buis 2020-06-13 09:39:26 PDT 
Created attachment 401839 [details]
Patch
Comment 2 EWS 2020-06-13 23:34:46 PDT 
Committed r263008: <https://trac.webkit.org/changeset/263008>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401839 [details].
Comment 3 Radar WebKit Bug Importer 2020-06-13 23:35:15 PDT 
<rdar://problem/64337106>